There might be (and maybe I might have encountered them) some edge-cases where the current model does not work properly.

Description
When testing for blockage, the king is counted as possible defender of squares. This leads to many positions that are wrongly counted as blocked.

To Reproduce
blockageKingIssue.txt
After the last move(Kd7-e6) the game detects a blocked position.

Desktop:

• OS: Win10
• Version alpha 0.1

fiveFoldIssue.txt
After any move a five fold repetition draw message is shown. This should have happen already after the black bishop was moved.

When saving in v3, only move history and start position are stored although promotions cannot always be reconstructed from the move history.
The most memory efficient way to solve this would probably be saving all promotions. Another solution is storing promotions in move history.

Description
When a piece cannot move because this would lead to a check, it is not as detected as blocked.

To Reproduce
Load stalemateIssue.txt.
This does unexpectedly not result in a stalemate.

Expected behavior
Normally black's last move (Rd4-b4) would result in a stalemate as white's king can't move because of the b rook and the bishop is pinned by the a3 rook.

Desktop:

• OS: windows 10
• Version alpha 0.1

In console UI:
When requesting help for a command that is unknown, it just prints the general help info instead of an error message.
E.g. :

help laod
===================<HELP>===================
 - HELP [command name] : Get help.
 - SAVE | S | WRITE | W <file path> : Save this game.
 - EXIT | HALT | STOP | DIE | END | SHUTDOWN  : Stop this BS.
 - RESIGN  : Resign the game.
 - TAKEBACK | T  : Take the last move back.
 - DRAW  : Propose a draw.
 - RESTART  : Restart the game.
 - MOVE | M <letter><digit><letter><digit> : Move a piece from one square to another.
 - LOAD <file path> : Load a saved game.
============================================

Make https://github.com/SlaynAndKorpil/Chess/blob/master/src/main/scala/chess/framework/StartPosition.scala for ClassicPosition to vals, this will save quite some computation.

Currently the GUI app opens the C:/Users/user/Documents/ folder to load and the console app needs a full path. Maybe use smth like [dir]/save/ ?

When parsing a save file with the status <boardStatus>Ended(Draw(Stalemate</boardStatus> it gives the following error:

java.lang.ClassCastException: chess.framework.BoardStatus.ResultReason.Resignation$ cannot be cast to chess.framework.BoardStatus.ResultReason.DrawResultReason
	at chess.framework.BoardStatus.GameResult.GameResult$.createResult(GameResult.scala:30)
	at chess.framework.BoardStatus.GameResult.GameResult$.apply(GameResult.scala:21)
	at chess.framework.BoardStatus.GameStatus.GameStatus$.apply(GameStatus.scala:25)
	at chess.framework.SaveLoader$Loader2$.load(SaveLoader.scala:223)
	at chess.framework.SaveLoader$.load(SaveLoader.scala:27)
	at chess.framework.ChessBoard$.loadExactPath(ChessBoard.scala:966)
	at chess.framework.ChessBoard$.load(ChessBoard.scala:958)
	at chess.framework.ChessIO.load(ChessIO.scala:100)
	at chess.framework.ChessIO.load$(ChessIO.scala:99)
	at chess.graphics.Board.load(Board.scala:130)
	at chess.graphics.CMenuBar$Menu$load$$anonfun$$lessinit$greater$8.apply(CMenuBar.scala:77)
	at chess.graphics.CMenuBar$Menu$load$$anonfun$$lessinit$greater$8.apply(CMenuBar.scala:71)
	at chess.graphics.CMenuItem$$anon$1.apply(CMenuItem.scala:13)
	at scala.swing.Action$$anon$1.actionPerformed(Action.scala:78)
	at java.desktop/javax.swing.AbstractButton.fireActionPerformed(AbstractButton.java:1967)
	at java.desktop/javax.swing.AbstractButton$Handler.actionPerformed(AbstractButton.java:2308)
	at java.desktop/javax.swing.DefaultButtonModel.fireActionPerformed(DefaultButtonModel.java:405)
	at java.desktop/javax.swing.DefaultButtonModel.setPressed(DefaultButtonModel.java:262)
	at java.desktop/javax.swing.AbstractButton.doClick(AbstractButton.java:369)
	at java.desktop/javax.swing.AbstractButton.doClick(AbstractButton.java:349)
	at java.desktop/javax.swing.plaf.basic.BasicMenuItemUI$Actions.actionPerformed(BasicMenuItemUI.java:935)
	at java.desktop/javax.swing.SwingUtilities.notifyAction(SwingUtilities.java:1805)
	at java.desktop/javax.swing.JComponent.processKeyBinding(JComponent.java:2901)
	at java.desktop/javax.swing.JMenuBar.processBindingForKeyStrokeRecursive(JMenuBar.java:699)
	at java.desktop/javax.swing.JMenuBar.processBindingForKeyStrokeRecursive(JMenuBar.java:706)
	at java.desktop/javax.swing.JMenuBar.processBindingForKeyStrokeRecursive(JMenuBar.java:706)
	at java.desktop/javax.swing.JMenuBar.processKeyBinding(JMenuBar.java:677)
	at java.desktop/javax.swing.KeyboardManager.fireBinding(KeyboardManager.java:311)
	at java.desktop/javax.swing.KeyboardManager.fireKeyboardAction(KeyboardManager.java:297)
	at java.desktop/javax.swing.JComponent.processKeyBindingsForAllComponents(JComponent.java:2994)
	at java.desktop/javax.swing.JComponent.processKeyBindings(JComponent.java:2986)
	at java.desktop/javax.swing.JComponent.processKeyEvent(JComponent.java:2863)
	at java.desktop/java.awt.Component.processEvent(Component.java:6355)
	at java.desktop/java.awt.Container.processEvent(Container.java:2259)
	at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:4961)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2317)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4793)
	at java.desktop/java.awt.KeyboardFocusManager.redispatchEvent(KeyboardFocusManager.java:1955)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.dispatchKeyEvent(DefaultKeyboardFocusManager.java:827)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.preDispatchKeyEvent(DefaultKeyboardFocusManager.java:1096)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.typeAheadAssertions(DefaultKeyboardFocusManager.java:966)
	at java.desktop/java.awt.DefaultKeyboardFocusManager.dispatchEvent(DefaultKeyboardFocusManager.java:792)
	at java.desktop/java.awt.Component.dispatchEventImpl(Component.java:4842)
	at java.desktop/java.awt.Container.dispatchEventImpl(Container.java:2317)
	at java.desktop/java.awt.Window.dispatchEventImpl(Window.java:2758)
	at java.desktop/java.awt.Component.dispatchEvent(Component.java:4793)
	at java.desktop/java.awt.EventQueue.dispatchEventImpl(EventQueue.java:766)
	at java.desktop/java.awt.EventQueue.access$500(EventQueue.java:97)
	at java.desktop/java.awt.EventQueue$3.run(EventQueue.java:717)
	at java.desktop/java.awt.EventQueue$3.run(EventQueue.java:711)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:89)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:99)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:739)
	at java.desktop/java.awt.EventQueue$4.run(EventQueue.java:737)
	at java.base/java.security.AccessController.doPrivileged(Native Method)
	at java.base/java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:89)
	at java.desktop/java.awt.EventQueue.dispatchEvent(EventQueue.java:736)
	at java.desktop/java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:199)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:124)
	at java.desktop/java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:113)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:109)
	at java.desktop/java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
	at java.desktop/java.awt.EventDispatchThread.run(EventDispatchThread.java:90)

and cannot complete parsing
ERROR graphics >> Failed to parse this file.

This will decrease the loading times.

Use n/N instead of wn/bn.
This will probably interfere with the loading/saving process. Yay, writing parsers is fun! :(

Request
When loading blockageKingIssue.txt the error message ERROR graphics >> Unable to load file C:\Users\user\Documents\blockageKingIssue.txt is printed although the file is located at this location, the correct loader gets selected and the loading process gets at least initialized.
There should be a more specific error message at this point in time.

Additional context
The load method of Loader2 throws a java.lang.StringIndexOutOfBoundsException: begin 5, end 41, length 21 exception.

ClassicPosition is implemented but not used.
It should be explicitly used in ChessBoard.classicalBoard to further minimize save file sizes.
It also needs to be implemented in framework.SaveLoader.Loader3.load as the special xml-elem is currently not parsed.

When loading saves that contain a game with a long history/ positions list or taking a move back in a long game it takes very long (2 sec and more) to load.

unableToMoveIssue.txt
King cannot move to b6.

Saving the current position is not neccessary anymore as this position can be calculated using the move history and the start position as well.

The pathfinding algorithm that tests for blockage often returns a false positive result.

repCountIssue.txt
After the last move (Qd3-1) there should be 1 repetition counted.

When generating the position history from a castling move, the rook does not get moved.

Recreation

1. Load castleIssue.txt
2. Go back a few moves and you can notice a white rook on A1, which just wasn't played correctly after white's long castle.

E.g. when replacing a piece id with "Z" no error is thrown.

When using the console interface, it gets cluttered quit fast. Maybe print additional empty lines after every output?

WTH is this not recognized as a stalemate?! :/ stalemateIssue.txt

When the input interpreter receives an empty input it still prints the error message. It should just ignore it so that you can add some spacing in the console yourself.

h6h5

Moved P from h6 to h5.

The move history still uses the toString method of the pieces instead of a single char id.

This position should be mate.

When a game that should be ended with a mate is in a position that would also be a stalemate (besides that the king is checked), the framework counts it as stalemate.

Describe the bug
When promoting to any piece and thereby checking the enemy's king, it does not get marked in red.

To Reproduce
Load the save promotionCheckProblem.txt and promote the pawn via capturing on B8 to a queen or a rook. This checks the king but it does not get displayed by the GUI.

Expected behavior
There should always be a visual feedback for check .

Desktop:

• OS: Windows 10
• Version alpha 0.1; 11.06.19

Right now when you press Ctrl S you will never get a file selection as either you already have saved a to a file or the standard "save" (see ChessIO.scala) is used as a file name. It would be more intuitive to only use the last save file name when you already chose a file. So the first time you save you would always get the file chooser.

Still not fully intuitive and uneasy to use. E. g. improvement is needed for interaction with pieces which is still a bit cluncy.

It is unnecessary to carry around a copy of framework.ChessBoard.classicalPosition, instead use def.`

Describe the bug
When adding reactions via a JReaction instance, often the generated isDefinedAt method of the PartialFunction that gets added to the reactions gives false positive results and causes errors like java.lang.ClassCastException: chess.framework.IOEvents.NoEvent$ cannot be cast to chess.framework.IOEvents.ShowEnded

To Reproduce
Add the following reactions to an implementation of chess.framework.JavaInterfacing.JChessIO:
addReaction(new JReaction<>(System.out::println)); addReaction(new JReaction<>((ShowEnded message) -> System.out.println("Game ended with a "+message.result())));

Expected behavior
Independend from the order should always when e.g a NoEvent is thrown the first reaction get called.

Desktop :

• OS: Windows 10
• Version alpha 0.1

Additional context
This problem is completely irrelevant 'cause nobody likes java.

The "capture" attribute of the "move" node in save files is unnecessary as it is unused. And should be able to be simply removed.

The apply method in framework.Column subtracts 1 from the index so you can use the actual row counting from the board to search for a piece. This heavily interferes with the inherited methods like map or foreach.

There is an edge-case of a possible piece-combination that can lead to a mate that is currently falsely handeled as draw due to insufficient material: K and B against K and N (KB can theoretically still mate)

The move history can be used to generate the position history. This will cause an immense reduce of filesize which should also reduce loading times.

load ".stalemateIssue.save"

ERROR: Unable to load file ".stalemateIssue.save"

load "./stalemateIssue.save"

ERROR: Unable to load file "./stalemateIssue.save"

load "C:\Users\user\Documents\stalemateIssue.save"

ERROR: Unable to load file "C:\Users\user\Documents\stalemateIssue.save"

Stalemate somehow does not work correctly.
stalemateIssue2.txt
After Ke2-e1 the game should be drawn.

Rework backend/framework so that a number of kings != 0 does not result in an runtime-error.
At many occasions in chess.framework.ChessBoard it is assumed that there is exactly one king per color.

This will otherwise cause problems when implementing suicide chess or a board editor.

The test returned true although black still had a queen.

Smh castling just does not work anymore. See castleIssue.txt.
Probably broken by a903fea.

Promotion is currently treated as an approval operation in console.InputInterpreter.
It just does not work at all like this.

Description
When the promotion-chooser popup window opens, you can actually just close it by pressing the red [X] button which will lead to game being stuck in a state in which the backend waits for a promotion and the frontend just does not allow to promote the piece.

Expected behavior
It should not be possible to close this window.

Save file in broken state