ScrollBlot.optimize() has invalid type about parchment HOT 5 CLOSED

Is this causing issues and if so what? The desire is to overload this function for ScrollBlot's needs for an array of mutations and ScrollBlot only pass context as the only parameter when it calls its superclass's optimize. The Typescript does not complain so I'm not seeing why it would be invalid.

from parchment.

The TypeScript compiler error only appears for me with the option strictNullChecks turned on. Since neither JS nor TS support method overloading, overridden methods need to be typeable as the superclass method type.

I think a simple fix would be switching the order of the arguments on ScrollBlot's optimize. I imagine this might break any consumers of ScrollBlot though.

from parchment.

A lot of other errors appear if strictNullChecks is turned on. Switching the order also does not get rid of the error as ContainerBlot's signature is only one parameter and ScrollBlot is two. I'm not seeing the practical benefits of this issue. Can you clarify what you are trying to do and how this is getting in the way?

from parchment.

Closing inactive issue.

from parchment.

There is an answer in TypeScript function overloading:

You can declare an overloaded function by declaring the function as having a type which has multiple invocation signatures

So, this might work:

optimize: {
  (context: { [key: string]: any }): void;
  (mutations: MutationRecord[], context: { [key: string]: any }): void;
};

from parchment.