Code Monkey home page Code Monkey logo

Comments (7)

matthewdavidson avatar matthewdavidson commented on June 9, 2024

Hey @fklein-lu! Thanks for this - the only instance I am aware of once instance of this:
https://github.com/Skyscanner/backpack/blob/master/packages/bpk-stylesheets/index.scss#L19

Is this what you are referring to?

from backpack.

fklein-lu avatar fklein-lu commented on June 9, 2024

Yes, this seems to be the only occurrence.

from backpack.

spacedmonkey avatar spacedmonkey commented on June 9, 2024

@fklein-lu Is there a fix this incoming? I get this message on every build

from backpack.

spacedmonkey avatar spacedmonkey commented on June 9, 2024

More information can be found on this issue here - sass/node-sass#2362

from backpack.

tiagoengel avatar tiagoengel commented on June 9, 2024

Hey @spacedmonkey we don't really have a solution for this. The warning has been reverted in [email protected] but the latest node-sass is using 3.5.4. It should eventually land on node-sass and remove this warning.

On top of that we will be actually changing all backpack components to import pre compiled css files in the near future, which should also get rid of this warning.

from backpack.

spacedmonkey avatar spacedmonkey commented on June 9, 2024

A better solution here would be not use css at all. How about using something like normalize-scss, which is a port of normalize.css to scss.

from backpack.

tiagoengel avatar tiagoengel commented on June 9, 2024

I'd say considering this is just a warning, that has been removed in the next version and considering we plan to ship only css files in the future, there is no need to do this right now.

We shipping pre compiled css files is to reduce the build time, it has nothing to do it this but it will also remove this warning.

from backpack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.