Code Monkey home page Code Monkey logo

Comments (4)

chpapa avatar chpapa commented on June 3, 2024

I think it is more optional and maybe can be a parameter in subscribe? If the developers don't care about other conversation they can simply ignore it at the logic?

On the other hand, I'm not sure if that have any implication to server loading / scalability.

from chat-sdk-js.

akiroz avatar akiroz commented on June 3, 2024

There are actually 2 versions of the typing indicator subscription: subscribeTypingIndicator and subscribeAllTypingIndicator, the first one filters by conversation and the 2nd one doesn't.
Kind of strange that there's only 1 subscribe (and I think it should be subscribeMessage).

from chat-sdk-js.

chpapa avatar chpapa commented on June 3, 2024

I agree subscribe is better renamed to subscribeMessage, found it odd when I first read it too.

from chat-sdk-js.

akiroz avatar akiroz commented on June 3, 2024

but now we can't rename it since the product is launched....... better add the new function and then do:

subscribe(...) {
  console.warn('subscribe is deprecated, please use subscribeMessage instead');
  ...
}

from chat-sdk-js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.