Comments (4)
I think it is more optional and maybe can be a parameter in subscribe? If the developers don't care about other conversation they can simply ignore it at the logic?
On the other hand, I'm not sure if that have any implication to server loading / scalability.
from chat-sdk-js.
There are actually 2 versions of the typing indicator subscription: subscribeTypingIndicator
and subscribeAllTypingIndicator
, the first one filters by conversation and the 2nd one doesn't.
Kind of strange that there's only 1 subscribe
(and I think it should be subscribeMessage
).
from chat-sdk-js.
I agree subscribe
is better renamed to subscribeMessage
, found it odd when I first read it too.
from chat-sdk-js.
but now we can't rename it since the product is launched....... better add the new function and then do:
subscribe(...) {
console.warn('subscribe is deprecated, please use subscribeMessage instead');
...
}
from chat-sdk-js.
Related Issues (20)
- All api that accept array of objects should also allow passing array of ids
- Missing various subscribe functions
- Update consistent error handling
- May have incompatible schema error when saving conversations
- Unable to subscribe to new user channel when logged in as another uaer HOT 2
- Browserify's standalone value is skygear, which duplicates with skygearJS SDK HOT 1
- [Discuss] Potential use of option for getUserConversations HOT 1
- Query error on _getUserConversation method
- createMessage asset param should accept skygear.asset object
- Utility Function for Typing Indicator with Input Box
- Travis build is broken for node v4 and node v5
- Skygear container in Skygear Chat cannot be configured in react-native HOT 2
- Rename hook to cloud
- getMessages() not working with get_messages lambda
- [Cache] Research on persistent store used in js HOT 2
- [Cache] Setup persistent store and models
- [Cache] Update message query and save API, call completion handler for cached result
- [Cache] Fetch unsent message api
- [Cache] Update fetch messages api by beforeMessageID and beforeTime
- In chat hooks should not inject the user_id into context manually
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from chat-sdk-js.