Container tests flaked out with `netcat: DockerResponseServerError { status_code: 404, message: "no container with name or ID \"e54dcb4xx\" found: no such container"` about skupper-router HOT 1 CLOSED

jiridanek commented on August 24, 2024

Container tests flaked out with `netcat: DockerResponseServerError { status_code: 404, message: "no container with name or ID \"e54dcb4xx\" found: no such container"`

from skupper-router.

Comments (1)

jiridanek commented on August 24, 2024

The linked PR probably fixes this, actually. The problem was that both h2spec and sanity tests use netcat container with the same name. The log suggests that first the netcat for sanity test started, and when h2spec netcat started (to run in parallel), it killed sanity's netcat container as the first thing. So when sanity test was looking for netcat result, its container was dead at that point (and it did not mistakenly use the h2spec container because subsequently it refers to the container by id and not by name).

skupper-router/tests/testcontainers/docker.rs

Lines 174 to 177 in 6055594

    
           pub(crate) async fn create_and_start_container(docker: &Docker, image: &str, name: &str, config: Config<&str>) -> ContainerCreateResponse { 
        
               let image_id = find_or_pull_image(docker, image).await; 
        
               // to be extra sure container does not already exist 
        
               delete_container(&docker, name).await;

So, regarding proper fix, the netcat container should have different name each time (test name should be a prefix, probably, and some random suffix sounds reasonable too).

from skupper-router.

Container tests flaked out with `netcat: DockerResponseServerError { status_code: 404, message: "no container with name or ID \"e54dcb4xx\" found: no such container"` about skupper-router HOT 1 CLOSED

Comments (1)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	pub(crate) async fn create_and_start_container(docker: &Docker, image: &str, name: &str, config: Config<&str>) -> ContainerCreateResponse {
	let image_id = find_or_pull_image(docker, image).await;
	// to be extra sure container does not already exist
	delete_container(&docker, name).await;