Comments (6)
I think this is still an issue, reopening. @fnhirwa, you are still welcome to pick this up if you´d like.
Yeah you can assign me I will start to work on it
from sktime.
made minor edits to include the fully reproducible example, hope that is ok.
Confirmed on current main
, windows, python 3.11
from sktime.
@guimalo As per the current logic, "holidays" present in the "holiday_windows" argument is expected to be present in the index of test dataframe as well, otherwise ValueError is raised.
from sktime.
@VyomkeshVyas, thanks for clarifying!
I would still consider this a "bug" in the sense that it is not obvious that the estimator will break (e.g., from docstring), and when it breaks it does not give clear feedback.
It is also not expected, as the holiday_windows
could in-principle intersect with the observed period, even if the event itself is not there.
I do think, hence, that the optimal state is:
- allow events outside the observed period - otherwise you will have to update the calendar continuously, and the estimator will fail for naive windowing or backtesting (!), because some events end up outside windows or folds
- a naive solution would be just to subset the calendar
- ensure that
holiday_windows
intersecting with observed data are properly treated- that might be more difficult, especially for non-contiguous dates. A simple solution might be to "grow" the holiday dates by their windows, then check if intersections come up empty
The above is my "optimal" resolution, the "minimal" would be a clear error message that explains to the user what they have to do. I would still consider that quite sub-optimal because the calendar has to vary with the data.
from sktime.
I am going to start looking into this item if no one is currently working on it
from sktime.
I think this is still an issue, reopening. @fnhirwa, you are still welcome to pick this up if you´d like.
from sktime.
Related Issues (20)
- [BUG] fix classifiers erroneously failing on non-int typed `y`
- [ENH] Add fine tuning methods using PEFT for `HFTransformersForecaster` HOT 3
- [BUG] `CNNClassifier` and `CNNRegressor` do not accept `filter_sizes` argument listed in docstring HOT 2
- [DOC] Misleading docstring parameters for convert utility function of dask_to_pd and vice versa
- [ENH] Logging intermediate results in forecasting benchmarking HOT 1
- [MNT] keras/transformers installation error on python 3.8-3.11 in CI HOT 2
- [ENH] EnbPI and SPCI algorithms
- [ENH][MNT] interface estimators from `neuralforecast` into `sktime`
- [BUG] `LabelEncoder` does not fit in a nested pipeline HOT 24
- [BUG] broken MACNNClassifier and MACNNRegressor
- [BUG] MCDCNNRegressor does not perform fitting/training?
- [BUG] CNTCRegressor raises an error on calling .fit()
- [BUG] In clustering averaging_method = 'dba' crashed HOT 3
- [ENH] categorical feature support: input checking - column type encoding by the `__dataframe__` protocol HOT 3
- [BUG] `TimeSeriesForestRegressor` failure - Parameter `self.criterion` does not exist in `TimeSeriesForestRegressor` HOT 1
- [BUG] pepy.tech downloads tracker on readme landing page is broken
- [BUG] Differencer is producing `SettingWithCopyWarning` HOT 3
- [ENH] wishlist: outlier detection, segmentation, change point detection (annotation module) HOT 3
- [MNT] Bump scikit-base to 0.8.0 HOT 1
- [BUG] failure of `test_differencer_cutoff` HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sktime.