Comments (4)
Ah, indeed! So you'd need to group it again before the bfill
, right?
Would you like to open a PR with a fix? Seems like the correct diagnosis already!
Your example would also make a good test.
from sktime.
Ah, indeed! So you'd need to group it again before the
bfill
, right?Would you like to open a PR with a fix? Seems like the correct diagnosis already!
Exactly! I'm happy to do so, I'll pick it up tomorrow.
from sktime.
Excellent.
Regarding the doc/logic mismatch, the standard way to address this is to change the doc, not the logic - to avoid to break currently working code.
Changing the logic can be done later, but should be accompanied by warnings etc - if we decide to do that.
from sktime.
EDIT: some profiling shows that the current solution is the fastest, even for a small dataframe. df.index.levels > 4
is approximately 1/3 slower than isinstance(df, MultiIndex)
:
>>> df = pd.DataFrame(dict(x=[1,2,3], y=[4,5,6]))
>>> timeit(lambda: isinstance(df, pd.MultiIndex), number=100000000)
6.388806922000015
>>> timeit(lambda: df.index.nlevels > 1, number=100000000)
9.203695821999986
Olde comment:
As a side-note, I'm not wasn't sure whether this is the best way to check for presence of a MultiIndex.
from sktime.
Related Issues (20)
- [MNT] keras/transformers installation error on python 3.8-3.11 in CI HOT 2
- [ENH] EnbPI and SPCI algorithms
- [ENH][MNT] interface estimators from `neuralforecast` into `sktime`
- [BUG] `LabelEncoder` does not fit in a nested pipeline HOT 24
- [BUG] broken MACNNClassifier and MACNNRegressor
- [BUG] MCDCNNRegressor does not perform fitting/training?
- [BUG] CNTCRegressor raises an error on calling .fit()
- [BUG] In clustering averaging_method = 'dba' crashed HOT 3
- [ENH] categorical feature support: input checking - column type encoding by the `__dataframe__` protocol HOT 3
- [BUG] `TimeSeriesForestRegressor` failure - Parameter `self.criterion` does not exist in `TimeSeriesForestRegressor` HOT 1
- [BUG] pepy.tech downloads tracker on readme landing page is broken
- [BUG] Differencer is producing `SettingWithCopyWarning` HOT 3
- [ENH] wishlist: outlier detection, segmentation, change point detection (annotation module) HOT 3
- [MNT] Bump scikit-base to 0.8.0 HOT 1
- [BUG] failure of `test_differencer_cutoff` HOT 4
- [BUG] `ForecastingHorizon` `M` and `Y` `freq` incompatibility with `pandas >=2.2.0` HOT 10
- [BUG] `PyKanForecaster` `TypeError: 'NoneType' object is not subscriptable` HOT 3
- [BUG] ForecastingSkoptSearchCV documentation example fails to run HOT 25
- [BUG] KNeighborsTimeSeriesClassifier.neighbor() failed HOT 3
- [MNT] track and confirm status of `scikit-optimize` HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sktime.