Comments (6)
I am working on adding an LTSF
algorithm, so I'll fix the author
tag.
I am closing the issue, as we have had a good discussion and have reached a conclusion to not change the API design.
from sktime.
Good observation!
I would go with the "implement a new one" plan.
Why: afaik, the current implementations are "reference implementations", taken from the cited repositories (which have not been released as packages on pypi).
So, they have - at least - an important place in comparisons, benchmarks, etc, for scientific purposes. Further, I'd imagine they are not fully interface identical with the neuralforecast
ones (I have not checked though).
Regarding the name, I would add as an option, perhaps we don't necessarily want to switch them, but keep neuralforecast
in the name, to give credit to neuralforecast
/ nixtla brand. So there's the original "academic" implementation which has been a reference for a while at least, and there's the nixtla implementation, which may or may not be improved, optimized, etc.
What do you think?
from sktime.
sure, I'll check how the original academic implemention and that of neuralforecast
and sktime
differs
from sktime.
hm, looks like nixtla
did the same thing and copied the code? That's a curious situation then.
If it is a 1:1 copy - like in sktime
- I see no reason to "outsource" it to nixtla
?
Because accessing the same code behind an additional layer of interfaces makes it more brittle - which in the case of nixtla
historically comes with substantial breakage risk (@yarnabrina probably has opinions on this, as the creator and maintainer of the statsforecast
facing one).
Further, nixtla
packages tend to take dependencies on all of pypi (exaggerating a little), while sktime
minimizes dependencies. This would make the dependency requirements, for users of the same estimator, worse.
from sktime.
hm, looks like
nixtla
did the same thing and copied the code? That's a curious situation then.
yes, I was checking DLinear
and it does look quite the same
Further,
nixtla
packages tend to take dependencies on all of pypi (exaggerating a little), whilesktime
minimizes dependencies. This would make the dependency requirements, for users of the same estimator, worse.
Yes, just observed the same thing, was working on nixtla
on colab and it takes really long to install all the packages unlike sktime.
Because accessing the same code behind an additional layer of interfaces makes it more brittle - which in the case of
nixtla
historically comes with substantial breakage risk
I think this and the above reasons are strong enough to keep LTSF
network implementations inside sktime
from sktime.
perhaps we should make the original authors aware that their algorithms exist in sktime
and are indexed?
I am also noticing, they do not appear in the author
tag, even though the code is copied. So, as an action, we should add the GitHub IDs of the original authors?
(this is my oversight, we added author/maintainer tags for estimators recently and we added them to 100s of estimators using default settings for the migration, based on file authors. Also see policy discussion in #5938 )
from sktime.
Related Issues (20)
- [ENH] design ideas for `fit` method in `momentfm`
- [BUG] Large loss amounts during training when using `hf_transformers_forecaster`
- [ENH] Pass an initialized pytorch-forecasting model directly
- [ENH] ensure `make_reduction` works with `skpro` proba regressors
- [ENH] probabilistic regressor support for `DirectReductionForecaster`
- [BUG] segmentation fails for change point detectors HOT 1
- [BUG] Dead image links in Signature Methods Section of docs HOT 3
- [BUG] table in API reference for transformer input/output tags does not display
- [ENH] Hosting moirai weights (old permissive license) on hugging face HOT 1
- [ENH] time series segmentation via clustering - reduction of time series segmentation to tabular clustering HOT 1
- [ENH] minimal episode length smoother for segmentations and change points HOT 2
- [BUG] CV calculation is incorrect in ADICVTransformer class HOT 10
- [BUG] error message for extras doesn't mention version constraints
- [DOC] De-duplicate User Guide & Examples
- [ENH] Reduce docs build time HOT 1
- [ENH] `autots` integration and work items
- [DOC] various documentation issues HOT 1
- [ENH] Add sampler with seed argument to ForecastingOptunaSearchCV HOT 3
- [MNT] How to deal with (foundation) models from packages not published on pypi HOT 10
- [ENH] Test all annotators with different index types
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sktime.