Code Monkey home page Code Monkey logo

Comments (6)

fkiraly avatar fkiraly commented on June 15, 2024 1

Fixed, here: #5741

What is odd, the module was never called classifiers afaik, this must have been a mistake in the original docstring.

from sktime.

fkiraly avatar fkiraly commented on June 15, 2024

Thanks fo reporting!

  • the module starting with underscore is private, so should not be directly accessed
  • the note sems outdated and ought to be fixed, though not sure what exactly it should change to

from sktime.

jmwhyte avatar jmwhyte commented on June 15, 2024
  • the module starting with underscore is private, so should not be directly accessed

In this case, the underscore form should not appear in the all_estimators() output, especially when the other (recommended) version does not appear in that output? Otherwise, users might just use the form of estimator they see output in this "encyclopaedia" of methods?

from sktime.

fkiraly avatar fkiraly commented on June 15, 2024

In this case, the underscore form should not appear in the all_estimators() output, especially when the other (recommended) version does not appear in that output?

Interesting, where does it appear?

If you convert a class to str, afaik it will always appear with its full path.

from sktime.

jmwhyte avatar jmwhyte commented on June 15, 2024

You can see what I describe after

from sktime.registry import all_estimators
all_estimators('classifier')

Starting from
"('Arsenal', sktime.classification.kernel_based._arsenal.Arsenal)"
there are many paths with the _ shown.

from sktime.

fkiraly avatar fkiraly commented on June 15, 2024

yes, I see - that's because the second element in the tuple is a class. When converted to string, the full path is always shown. Not sure how to change that.

str(all_estimators('classifier')[0][1]) gives <class 'sktime.classification.kernel_based._arsenal.Arsenal'>

Suggestions welcome.

from sktime.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.