Code Monkey home page Code Monkey logo

Comments (10)

skorokithakis avatar skorokithakis commented on August 12, 2024

Ah, thank you. Are you using an Arduino to run the sketch on, or an ESP8266? I'm not sure what __attribute__((used)) does or what it's compatible with...

from a6lib.

skorokithakis avatar skorokithakis commented on August 12, 2024

Doesn't seem to hurt anything, so I've implemented it, thanks!

from a6lib.

BJDayzz avatar BJDayzz commented on August 12, 2024

from a6lib.

skorokithakis avatar skorokithakis commented on August 12, 2024

I tried it on the ESP8266 and it looks like it works fine, thanks for the heads up! Is the module working well for you?

from a6lib.

BJDayzz avatar BJDayzz commented on August 12, 2024

from a6lib.

BJDayzz avatar BJDayzz commented on August 12, 2024

from a6lib.

skorokithakis avatar skorokithakis commented on August 12, 2024

Thanks for the contribution (but please open separate issues for separate things). You can create a pull request by following this guide:

https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github

It looks much worse than it is, in reality you just click the "fork" button at the top, make the changes in your repo, push them and click "create pull request", and that's it.

from a6lib.

skorokithakis avatar skorokithakis commented on August 12, 2024

I've added your code, thank you! It would have taken me much less time to review/accept if it were in a PR, but it was small enough to add by hand, thanks again!

from a6lib.

BJDayzz avatar BJDayzz commented on August 12, 2024

from a6lib.

skorokithakis avatar skorokithakis commented on August 12, 2024

It did get added, yes :)

It means "pull request", it's just a thing that tells me "please integrate my changes" and shows me the changes in a diff.

from a6lib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.