Comments (10)
Done #46
from skooner.
Also the age seems wrong to me.
If you need more informations to reproduce the issue, let me know.
from skooner.
Hey @kvpt. I'm using an npm package for converting the date into "age" and unfortunately the letter "m" for both minutes and months :(
Does that explain what you're seeing?
from skooner.
Oh yes you're right, the second screenshot show that.
from skooner.
@herbrandson this library has not been updated for years now. I kinda guess you've switched from Moment.js to it for performance reason. Would you like to have a PR with another lib in k8dash or a PR in the time-ago project to merely fix the specific use case (milliseconds vs minutes vs month, all represented by 'm') ?
Btw, thanks for this amazing project k8dash ;)
from skooner.
I suspect the easiest route would be a pr in k8dash (which I would love!). Is there a specific library you're considering?
from skooner.
@herbrandson what about humanize-duration
?
var humanizeDuration = require("humanize-duration")
const shortEnglishHumanizer = humanizeDuration.humanizer({
language: 'shortEn',
languages: {
shortEn: {
y: () => 'y',
mo: () => 'mo',
w: () => 'w',
d: () => 'd',
h: () => 'h',
m: () => 'm',
s: () => 's',
ms: () => 'ms',
}
}
})
var nd = 1554401268000; // 4/4/2019
var diff = Date.now() - new Date(nd).getTime()
shortEnglishHumanizer(diff).split(",")[0]
// => "8 mo"
from skooner.
LGTM. Do you want to create a PR?
from skooner.
@herbrandson Yes, I'll try to do that this week :-)
from skooner.
Thanks for the PR! It's been merged and this should now be resolved :)
from skooner.
Related Issues (20)
- Need to enable https in skooner HOT 4
- Where are the helm charts? HOT 8
- Up and running with oidc via Dex - metrics URLs return 403s HOT 2
- Bug: RAM Request/Limits calculation is incorrect. HOT 1
- Auth Token HOT 7
- OIDC api is failing . Due to internal error
- How to troubleshoot OIDC issues? HOT 2
- Skooner not displaying Deployments HOT 1
- Running skooner with subpath HOT 1
- Does Skooner support OIDC PKCE Auth HOT 3
- Pods: Ready vs Requested should exclude pods in Succeeded state HOT 1
- kubernetes-skooner.yaml does not declare any CPU/RAM request HOT 1
- Can Skooner base path be changed from / ? HOT 2
- Skooner erroring all of a sudden HOT 4
- Add arm64 support HOT 1
- OIDC Login with AzureAD POST /apis/authorization.k8s.io/v1/selfsubjectrulesreviews 401 HOT 4
- Open ID Manifests with `authorization_response_iss_parameter_supported=true` 500's on authorization flows with `iss missing from the response` HOT 8
- Issue with Keycloak and Skooner - fail to login within keycloack 401 HOT 1
- Add ability to perform custom branding
- Upgrade from node 16
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from skooner.