Code Monkey home page Code Monkey logo

Comments (9)

Skeletonxf avatar Skeletonxf commented on August 16, 2024

I don't believe it is possible to read the browser config settings. It should be easy enough to create a setting for the addon directly for that configuration however.

from duplicate-tab.

exec228 avatar exec228 commented on August 16, 2024

Salut!
Is it possible in 2020 to insert it "aftercurrent" while

browser.tabs.insertAfterCurrent=false
browser.tabs.insertRelatedAfterCurrent=false

?

Because duplicate is not "related". It IS the tab :-)

from duplicate-tab.

Skeletonxf avatar Skeletonxf commented on August 16, 2024

I don't understand what you mean?

from duplicate-tab.

Skeletonxf avatar Skeletonxf commented on August 16, 2024

This should be technically possible because duplicating a tab via an addon follows the addon APIs and there is an option to specify the new position. I'm assuming setting browser.tabs.insertAfterCurrent to false does not affect how Duplicate Tab positions new tabs currently because otherwise this issue would not have been opened.

from duplicate-tab.

exec228 avatar exec228 commented on August 16, 2024

Salut!

1.My browser intentionally opens new tabs (links, bookmarks) at ultimate right. Not aftercurrent.
Thus I have:
browser.tabs.insertAfterCurrent;false
browser.tabs.insertRelatedAfterCurrent;false

2.And on closing tab I don't want jump to OwnerOnClose.
Thus I have:
browser.tabs.selectOwnerOnClose;false

BUT: duplicate is neither "new tab", nor "related tab". It is the tab. Just cloned.
I want duplicate tab to be inserted right after original tab.
Despite settings named, which I have about 15 years that way, and I'm okay with these.

Is it possible?

Thank you!

from duplicate-tab.

Skeletonxf avatar Skeletonxf commented on August 16, 2024

browser.tabs.insertRelatedAfterCurrent is the relevant one here

@dswhite42 despite no change to the addon code it is now respecting this setting on my version of Firefox 78
@exec228 because Firefox is now applying this setting to the duplicated tab, to support every combination there needs to be a three way configurable option

1 - (current behaviour) let the browser choose where the duplicated tab is placed, which follows the browser.tabs.insertRelatedAfterCurrent setting
2 - override the choice and always put the duplicated tab just after the original
3 - override the choice and always put the duplicated tab at the end

Adding support for 2 and 3 are both definitely possible but will require a bit of work to keep track of the indexes of the tabs

from duplicate-tab.

exec228 avatar exec228 commented on August 16, 2024

Understood.
Thank you for reply!

from duplicate-tab.

Skeletonxf avatar Skeletonxf commented on August 16, 2024

Just as a disclaimer I currently have no way to test addons on mobile due to the state of Firefox for Android so even if I finish the code for this soon it might be a while before I release to addons.mozilla.org

from duplicate-tab.

Skeletonxf avatar Skeletonxf commented on August 16, 2024

This has now been implemented and released on AMO as version 2.2

from duplicate-tab.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.