Code Monkey home page Code Monkey logo

Comments (6)

Skallwar avatar Skallwar commented on July 29, 2024 2

I suggest basic_auth because we may encounter different domain with different username/password. This way before making a request, we could fetch in a data structure (maybe a hashtable) a username/password.

From the command line, we need to be able to specify triplets separated with a , (or something else) with domain/username/password.
Reading from a file the same data could be better at first

from suckit.

Skallwar avatar Skallwar commented on July 29, 2024 1

@Skallwar I'm interested in taking this on if it's available!

Go ahead ;)

from suckit.

Skallwar avatar Skallwar commented on July 29, 2024

Yes, thanks for the report 👍

from suckit.

pjsier avatar pjsier commented on July 29, 2024

@Skallwar I'm interested in taking this on if it's available!

from suckit.

pjsier avatar pjsier commented on July 29, 2024

@Skallwar from looking into this a bit, it looks like HTTP basic auth is already supported by reqwest if you supply the credentials in the URL itself like "https://username:[email protected]/". Is this still something you'd want to implement command line options for?

If so, from what I'm seeing we could either set default HTTP basic auth headers in the client field of Downloader which would require adding the base64 crate as an explicit dependency (because reqwest only has a helper method for RequestBuilder), or we could add username and password fields to Downloader that are set either on each URL or on each request.

Let me know what you think the best approach is, thanks!

from suckit.

CohenArthur avatar CohenArthur commented on July 29, 2024

Closed with #96

from suckit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.