Code Monkey home page Code Monkey logo

Comments (10)

SpyrosRoum avatar SpyrosRoum commented on July 29, 2024

destination will always be a directory, right?

from suckit.

Skallwar avatar Skallwar commented on July 29, 2024

destination will always be a directory, right?

No, a file

from suckit.

SpyrosRoum avatar SpyrosRoum commented on July 29, 2024

Hm to be honest I am not really sure I get why you need to create symlinks at all but assuming it's always for a file, I can do that with windows::os::fs::symlink_file

from suckit.

Skallwar avatar Skallwar commented on July 29, 2024

Hm to be honest I am not really sure I get why you need to create symlinks at all but

Sometime we discover a link wich is a pdf (eg. test.org/pdf/test.pdf). So a page wich contain a link to this file will replace every test.org/pdf/test.pdf by test_org_pdf_test_pdf. But the real name of this pdf (test.pdf) is only found when actualy processing the url (test.org/pdf/test.pdf). At this point we save the pdf to it's real filename and create a symlink between test.pdf and test_org_pdf_test_pdf

I can do that with windows::os::fs::symlink_file

Should be this one indeed

from suckit.

SpyrosRoum avatar SpyrosRoum commented on July 29, 2024

If you know of a url that needs this I can try to do it. Is that the only reason why it doesn't work in windows?

from suckit.

CohenArthur avatar CohenArthur commented on July 29, 2024

We think it's the only reason but haven't tried. There might be more to it. If you have a windows build available, feel free to try. I'll add it to the CI as well

from suckit.

SpyrosRoum avatar SpyrosRoum commented on July 29, 2024

I have a vm I can use but from what I understand it doesn't happen with every page you try to download, right?

from suckit.

CohenArthur avatar CohenArthur commented on July 29, 2024

True, symlinks aren't always created. The code calling disk::symlink() is here

from suckit.

SpyrosRoum avatar SpyrosRoum commented on July 29, 2024

I know, I am asking if you already know of a page that requires symlinks so I can easily test it

from suckit.

CohenArthur avatar CohenArthur commented on July 29, 2024

Oh my bad, sorry about the confusion. Any page downloading PDFs basically, so a page like https://dl.acm.org/doi/book/10.1145/3368274 is good.

from suckit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.