Code Monkey home page Code Monkey logo

Comments (9)

joseluisametller avatar joseluisametller commented on May 18, 2024

I can reproduce it as well, at least on KitKat. I'm using 1.4.0 for the moment...

from materialtaptargetprompt.

sjwall avatar sjwall commented on May 18, 2024

Hi, thanks letting me know about the issue.

It looks like the issue is occurring due to changes made in d70026e, it is incorrectly applying the status bar height when it has already clipped the bounds to the activity.

I hope to have a fix out later today or tomorrow

from materialtaptargetprompt.

sjwall avatar sjwall commented on May 18, 2024

Changes released in v1.4.2, could you please confirm that these changes fix this issue?

from materialtaptargetprompt.

joseluisametller avatar joseluisametller commented on May 18, 2024

Using 1.4.2 on my gradle file I can still reproduce it on KitKat.

from materialtaptargetprompt.

sjwall avatar sjwall commented on May 18, 2024

The issue is effecting KitKat and lower

from materialtaptargetprompt.

sjwall avatar sjwall commented on May 18, 2024

Issue is the call to mClipToView.getLocationOnScreen(location); in updateClipBounds().
It is correctly returning the views screen position from top on KitKat and lower. On Lollipop and newer this returns 0 all the time.

Working on fix for this

from materialtaptargetprompt.

sjwall avatar sjwall commented on May 18, 2024

Should be fixed now and released in v1.4.3. Found different way of retrieving the activity screen location. @joseluisametller and @grote could you both please confirm that this fixes the issue for you? I have tested it with Transportr on Kitkat and Nougat, so I have high hopes

from materialtaptargetprompt.

joseluisametller avatar joseluisametller commented on May 18, 2024

@sjwall I can confirm it is working perfectly fine on KitKat. Thanks a lot for your work :D

from materialtaptargetprompt.

sjwall avatar sjwall commented on May 18, 2024

@joseluisametller Thanks for confirming. Closing as issue has been fixed

from materialtaptargetprompt.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.