Comments (7)
sir-gawain
commented on June 11, 2024
1
the change was done in commit TYPO3/typo3@7e6a9da
i think the easiest fix would be to simply copy the changes from this commit. The class ImageService also exists in T3 10 and only the injection changed, so this should be fine.
from sms-responsive-images.
Hobokens
commented on June 11, 2024
Hi,
thanks for the hint. Do I have to replace it everywhere?
from sms-responsive-images.
s2b
commented on June 11, 2024
Thank you for the bug report. In order to stay compatible with TYPO3 10, just replacing the variable isn't enough. I'm not sure when I'll find the time to address this, but until then I would be happy to review/accept pull requests.
from sms-responsive-images.
s2b
commented on June 11, 2024
Seems like this will be changed/fixed again in TYPO3 11.4. So I will probably not apply my bugfix in the referenced pull request.
https://review.typo3.org/c/Packages/TYPO3.CMS/+/70245
from sms-responsive-images.
s2b
commented on June 11, 2024
Should be fixed with 11.4, worked in my local testing environment.
from sms-responsive-images.
sir-gawain
commented on June 11, 2024
Does it work now? I updated the project to 11.4 and the error is still there.
from sms-responsive-images.
s2b
commented on June 11, 2024
We checked again with a local test installation, it worked fine in our case. If the problem persists, could you be more specific and create a new issue for that?
from sms-responsive-images.
Related Issues (20)
- Idea: preload images HOT 4
- Respect CropArea while generating placeholder image HOT 3
- Support for TYPO3 11
- Automated testing and TER release
- Is there any reason you don't add a height attribute to fallback image? HOT 3
- [BUG] Attributes loading and fileExtension are not in Typo3 v.9.5 HOT 1
- Not providing a width attribute throws error HOT 2
- Idea: support webp extension as fallback HOT 2
- TYPO3 Extension Award - Best Documentation 2021
- No scaling with empty `crop` (in TYPO3 v11) HOT 2
- srcSet is generated differently on remote server than in local DDEV environment HOT 2
- placeholderInline + unscaleable main image = inline huge base64 main image HOT 4
- Wrong encoding of crop-attribute's array HOT 3
- Apply selectedRatio if crop-attribute is set HOT 5
- ViewHelper classes should not be final HOT 8
- Request: Coerce VH `sizes` argument to `string` before calling `createImageTagWithSrcset` HOT 2
- width="xxx" not working anymore
- Set height attribute on img-tag when using lazy loading
- Allow to install on TYPO3 v13
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sms-responsive-images.