Comments (6)
thanks for posting! I'm actually basing the version of jquery on the version they use themselves on the documentation site. You'll see if you inspect getbootstrap.com that they are actually using jquery 1.11.0 <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js"></script>
. Because of this I will most likely change the jquery dependency to 1.11.0 on the next package release.
from twitter-bootstrap-nuget.
I respect your reasoning, but I don't think that the source code of the
documentation website should be leading in this case.
Dependency management is made explicit in the bower.json file.
Off course I can't force you to change the jQuery dependency to 1.9, but I
hope you will reconsider.
Op vrijdag 7 maart 2014 heeft Chris Kirby [email protected] het
volgende geschreven:
thanks for posting! I'm actually basing the version of jquery on the
version they use themselves on the documentation site. You'll see if you
inspect getbootstrap.com that they are actually using jquery 1.11.0 <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.0/jquery.min.js "></script> . Because of this I will most likely change the jquery
dependency to 1.11.0 on the next package release.—
Reply to this email directly or view it on GitHubhttps://github.com//issues/31#issuecomment-37040003
.
Groeten,
Maarten
from twitter-bootstrap-nuget.
I certainly understand. Some people would prefer the choice to upgrade given that the min supported version is 1.9. However this the first opinion I've heard on this, so I'll just leave this issue open for now to see if there are others who support this as well. I think most, myself included, would prefer to use the latest supported version instead of the minimum required version. There is rarely a benefit to not doing this, other than issue with cross dependencies. Nuget unfortunately doesn't handle all of those scenarios and could automatically update jquery project wide when another package may set a version ceiling on their jquery dependency. Because of that fact, I could see a compelling argument for only taking dependency on the min required version to avoid potential conflicts with other packages.
from twitter-bootstrap-nuget.
going to address this in issue #36
from twitter-bootstrap-nuget.
Great news! Thank you Chris!
What made you change your mind?
from twitter-bootstrap-nuget.
Ultimately I just came to agree with you that this should be best practice. Even though the user would most likely benefit from the forced upgrade in the case of jquery, it simply isn't necessary to run bootstrap properly. That, and I do not want to unintentionally break other packages that may only support a lesser version of jquery. Thanks again for posting the issue!
from twitter-bootstrap-nuget.
Related Issues (20)
- Remove Less.js dependency HOT 1
- Dependency on bootsrap 3.1.1 that doesn't exist HOT 3
- Error when creating a controller HOT 3
- Wrong comment syntax HOT 2
- Sample Project? HOT 5
- What's the different by installing this package? HOT 6
- External packages cannot depend on packages that target projects HOT 1
- Update nuget package to v3.2.0 release
- missing the mixins less files on latest package update
- Create a sass nuget package from the official ported source HOT 4
- update source and package to v3.3.0 release
- Update to Bootstrap 3.3 sources HOT 2
- update to v3.3.1.source
- Update package to v3.3.2 release
- update package to v3.3.5 source
- Next package version will redirect to new official Bootstrap.Less package
- thanks HOT 1
- Update package to v3.3.6 source HOT 2
- CVE-2018-20676 & 20677 will library be updated?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twitter-bootstrap-nuget.