Code Monkey home page Code Monkey logo

Comments (7)

sir-dunxalot avatar sir-dunxalot commented on May 11, 2024

I think the second part of that (checking the type/constructor of tooltip) is reasonable. The first part, about renaming the tooltip property seems like more of an odd edge case. My reasoning being that this is the tooltip library and, thus, should probably own the tooltip property. I get there are some situations that will overlap (e.g. using a UI library that has tooltips built in) but let's implement the second part of your fix and reassess if it continues to be a pain. How does that sound?

from ember-tooltips.

coladarci avatar coladarci commented on May 11, 2024

To my knowledge, checking the constructor in JS is a dogey area - I have a simpler fix in a local branch - #48 - pretty "hacky" but our prod site went down so I needed something quick :) Thoughts?

from ember-tooltips.

coladarci avatar coladarci commented on May 11, 2024

Another way I've handled this in the past is to add a property to your tooltip object, like isEmberTooltip, so you can replace this conditional w/ a check for that property. Still hacky but a little more explicit.. Thoughts?

from ember-tooltips.

sir-dunxalot avatar sir-dunxalot commented on May 11, 2024

I think either of those should work. The underlying library has a Tooltip class so I think we'd be ok there. But I defer to you if you know of any other issues checking the constructor. I'll test it out and if that doesn't work we'll use the second approach - I've used it in multiple projects before and it's been reliable.

from ember-tooltips.

coladarci avatar coladarci commented on May 11, 2024

Hey @sir-dunxalot - have you had a chance to check this out? Thanks!

from ember-tooltips.

sir-dunxalot avatar sir-dunxalot commented on May 11, 2024

Sorry, not yet. I'll try to do so before the weekend. Thanks for the reminder.

from ember-tooltips.

sir-dunxalot avatar sir-dunxalot commented on May 11, 2024

This should be fixed by #48, which is now on master and released. If you're still having issues we can reopen this issue.

from ember-tooltips.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.