Comments (7)
I think the second part of that (checking the type/constructor of tooltip
) is reasonable. The first part, about renaming the tooltip
property seems like more of an odd edge case. My reasoning being that this is the tooltip library and, thus, should probably own the tooltip property. I get there are some situations that will overlap (e.g. using a UI library that has tooltips built in) but let's implement the second part of your fix and reassess if it continues to be a pain. How does that sound?
from ember-tooltips.
To my knowledge, checking the constructor in JS is a dogey area - I have a simpler fix in a local branch - #48 - pretty "hacky" but our prod site went down so I needed something quick :) Thoughts?
from ember-tooltips.
Another way I've handled this in the past is to add a property to your tooltip object, like isEmberTooltip, so you can replace this conditional w/ a check for that property. Still hacky but a little more explicit.. Thoughts?
from ember-tooltips.
I think either of those should work. The underlying library has a Tooltip
class so I think we'd be ok there. But I defer to you if you know of any other issues checking the constructor. I'll test it out and if that doesn't work we'll use the second approach - I've used it in multiple projects before and it's been reliable.
from ember-tooltips.
Hey @sir-dunxalot - have you had a chance to check this out? Thanks!
from ember-tooltips.
Sorry, not yet. I'll try to do so before the weekend. Thanks for the reminder.
from ember-tooltips.
This should be fixed by #48, which is now on master and released. If you're still having issues we can reopen this issue.
from ember-tooltips.
Related Issues (20)
- Having popover style the same as tooltip HOT 2
- Disable all ember-tooltips styles HOT 1
- Positioning the pointer/arrow so it's not always centered in 3.x HOT 10
- Ember Tooltip v3.4.0 shows a tooltip outside the browser window HOT 10
- Update documentation and tests to use Octane features
- Remove tooltip from DOM on hide HOT 3
- Issue with tooltip positioning HOT 4
- Upgrade to popper@2? HOT 8
- Deprecation warnings with Ember 3.20 HOT 5
- Wrong Sentence at line 335 of README file
- IE 11 - Not working due to js errors HOT 6
- Hiding popover on target click or inside click HOT 1
- onHide triggers even if tooltip wasn't shown HOT 1
- Deprecation warning: Using `run.bind` has been deprecated HOT 2
- Must use import to load ES Module eslint-scope/lib/definition.js HOT 2
- Increased memory usage on 3.5.1
- Remove use of ember global Ember.testing
- Security Vulnerability: glob-parent@<5.1.2
- Popover showing behind elements below HOT 1
- Add Glint TypeScript types
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ember-tooltips.