heplify-server stopped executing unexpectedly about heplify-server HOT 4 CLOSED

Hi,
it seems you have a malformed hep packet and reached this line
chunkBody := hepChunk[6:chunkLength]

I thought I have enough checks that this case never occurs but it seems I must have missed one case. Lets go through my checks.

1. First I check if the packetlength is the same like the heplength this is how it looks like in code:

	if int(length) != len(packet) {
		return fmt.Errorf("HEP packet length is %d but should be %d", len(packet), length)
	}

2. For every chunck I check if the chuncklength isn't greater than the remaining hepChunks:

		if len(hepChunk) < int(chunkLength) {
			return fmt.Errorf("HEP chunk overflow %d > %d", chunkLength, len(hepChunk))
		}

3. You get to following line and heplify-server crashes:
   chunkBody := hepChunk[6:chunkLength]

Since chunkLength couldn't be greater than hepChunk due to the 2. check this means chunkLength is < 6

So I will change the 2. check to

		if len(hepChunk) < int(chunkLength) || int(chunkLength) < 6 {
			return fmt.Errorf("HEP chunkLength is wrong %d len hepChunk %d", chunkLength, len(hepChunk))
		}

from heplify-server.

I will release today or mby tomorrow a new release with the fix. When you use heplify as hep client you can avoid hep and use protobuf. Simply run heplify with -protobuf flag

from heplify-server.

Latest release has a stronger hep validation and should catch your corner case.
https://github.com/sipcapture/heplify-server/releases

from heplify-server.

If you still have issues feel free to reopen.

from heplify-server.