WARN addHdr err: no semi found in about heplify-server HOT 9 CLOSED

I throw addHdr err: no semi found in: %s" whenever there is no ":" the header line. At this point in code I expect following:

headername: headervalue

As you can see here:
https://github.com/negbie/sipparser/blob/master/parser.go#L138
I print the whole header line and when I look at your error message above it seems the header line was not splitted correctly by "\r\n"

from heplify-server.

When I look at your first error I see:

CSeq: 3047 REGISTER\r\n
WWW-Authenticate: Digest realm="..*.",\r\n nonce="xWg1DnB3QqPdiSYw8jsH0g==",algorithm=MD5\r\n

So although its an error for you the parser acts correctly.
As I said the headers will be split by "\r\n"
So it will split the headers like following

CSeq: 3047 REGISTER
WWW-Authenticate: Digest realm="..*.",
nonce="xWg1DnB3QqPdiSYw8jsH0g==",algorithm=MD5

The problem here is that the useragent puts "\r\n" in the middle of the WWW-Authenticate header. Do you know if this is rfc conform?

Same for the second error
Authorization: Digest username="+@...",\r\n realm="...",nonce="aWo/bi1Gr0/Mdgr4aW295Q==",\r\n uri="sip:..*.",\r\n

"\r\n" in the middle of the Authorization header

from heplify-server.

I have check the RFC3261, from my understanding, it seems the \r\n are not placed correctly. They did not follow the standard. Will check with my vendor to see if they have an explanation.

from heplify-server.

In the best case they will fix it but it will take a while. What I can do is to check if we have at least the mandatory sip headers and go ahead with the processing. It seems I handle sip parsing errors to strict right now.

from heplify-server.

Got a feedback from the vendor, i miss out one of the syntax. So actually the syntax is correct (the \r\n is placed correctly - it is an optional part)

RFC3261：
WWW-Authenticate = "WWW-Authenticate" HCOLON challenge
challenge = ("Digest" LWS digest-cln *(COMMA digest-cln))
COMMA = SWS "," SWS ; comma
SWS = [ LWS ] ; sep whitespace
LWS = [ WSP CRLF ] 1WSP ; linear whitespace

Did some testing on my own for changes to parser.go at the sipparser. I commented out the error reporting for "no semi found in xxx" and manually set sp=0. I figure that since there is no semi, it is not a header anyways so it can be ignored.

func (s *SipMsg) addHdr(str string) {
	if str == "" || str == " " {
		return
	}
	sp := strings.IndexRune(str, ':')
	if sp == -1 {
		sp = 0
		//s.Error = fmt.Errorf("addHdr err: no semi found in: %s", str)
		//return
	}

from heplify-server.

Try to comment only the error message

from heplify-server.

Owww thats a much better way of doing it. don't need to continue processing since it is not a header.
I tried it, it is working well.

from heplify-server.

Fixed with latest commit.

from heplify-server.

thank you 😄

from heplify-server.