Comments (5)
What do you think should happen? Throw an error in such case? Add an option for what to do?
from trash.
I want to use this package as a fallback for Electron's shell.moveItemToTrash
, but it seems Trash removes the files permanently if it fails to trash them.
The electron function is able to detect the errors somehow avoid the deletion.
Edit: They have switched to shell.trashItem
recently for the unreleased Electron 13
from trash.
IMO it should ideally throw an error when it cannot trash the file, because the reason why I use this library, is so that the user doesn't lose their file immediately. If trash
permanently deletes a file, then IMO it did not do its job. But maybe it's not possible to make sure that it never permanently deletes a file.
from trash.
I agree. It should be a custom Error
subclass though, so consumers can easily catch it and decide what to do.
Continued in sindresorhus/recycle-bin#8.
from trash.
IMO it should ideally throw an error when it cannot trash the file, because the reason why I use this library, is so that the user doesn't lose their file immediately.
I see the reasoning here, but it conflicts with a use case where Windows user can configure their Recycle bin to delete files immediately. In this scenario deleting files instead of moving them to trash is what the user wants, and throwing errors here would be wrong.
So unless you can check that file is being deleted from a drive that doesn't have immediate deletion enabled, you shouldn't throw errors.
from trash.
Related Issues (20)
- can not use in win32 os HOT 1
- Remove from trash bin? HOT 1
- Confusion for Windows + WSL HOT 2
- zsh: command not found: trash HOT 2
- Trouble deteting some files HOT 3
- Error on Linux if user never deleted any files HOT 2
- feat: read the recycle bin/trash folder HOT 1
- ERR_REQUIRE_ESM when including this in another project HOT 2
- A quote about express
- The import Trash will report ERROR HOT 1
- Webpack is not supported HOT 1
- no such built-in module HOT 2
- Contribution π¬: Perhaps 'procfs' dependency isn't really needed? HOT 1
- θ½ζδΎθΏεε ι€ηζΉζ³ε Can you provide a method for restoring deletion HOT 1
- How to tell whether deletion succeeded? HOT 2
- Doesn't find correct Trash folder on NixOS
- Files are renamed to a hash in KDE HOT 1
- Windows support no Win 7? HOT 1
- Readme should mention how to include the binaries HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from trash.