Code Monkey home page Code Monkey logo

Comments (5)

floatdrop avatar floatdrop commented on April 28, 2024

I thought this would do for path and pathname https://github.com/sindresorhus/got/blob/master/index.js#L50-L52

    if (opts.pathname) {
        opts.path = opts.pathname;
    }

from got.

julien-f avatar julien-f commented on April 28, 2024

Yes but the issue is there https://github.com/sindresorhus/got/blob/master/index.js#L59

from got.

julien-f avatar julien-f commented on April 28, 2024

I should probably not use both path and query but this is not explicit in the doc and it worked in 3.2.

from got.

floatdrop avatar floatdrop commented on April 28, 2024

@julien-f I'm really thinking about standalone module for parsing and normalization.

from got.

floatdrop avatar floatdrop commented on April 28, 2024

This could be resolved, if we drop pathname support in options (since it not used in [http.request](https://nodejs.org/api/http.html#http_http_request_options_callback and in docs we claim that only request options are supported) and will not use url.format to create message (to avoid #72 regression).

from got.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.