Set Content-Type on POST requests about got HOT 8 CLOSED

What does request do?

from got.

They have a form option https://github.com/request/request#applicationx-www-form-urlencoded-url-encoded-forms.

When thinking of it, maybe it makes sense to keep the defaults as they are. Form submission in a node environment might not be the top use case for POSTs (although it's kinda weird having to define when used in a browser environment).

from got.

cc @floatdrop @julien-f @arthurvr @shinnn

from got.

As a user I do not mind setting the content type myself if I already have to format my data.

from got.

It make sense in browser environment, but in node (if body is String) text/plain is more accurate (String is plain text, right?). I'm not sure about Stream thou - it can be binary/octet-stream by default.

Maybe mention it in readme somehow (like - example how to send form data)?

from got.

@kevva maybe, if body is plain object, it makes more sense to setup content-type and stringify object for user?

got.post('http://somesite.com', {
    body: {
        search: 'text'
    }
});

from got.

@kevva ⬆️

from got.

@floatdrop, yes, that'd be really useful.

from got.