Comments (3)
I think we should if the response content-type is JSON.
from got.
@sindresorhus well, this will introduce content-type matching, which I like to avoid. This still could be done in userland (because data is passed to callback anyway):
got('nginx.com/errored', funciton (err, data, res) {
if (err) {
// Explicitly says, that we expect non-json responses
if (/text\/json/.test(res.headers['content-type'])) {
//...
}
}
});
And it will be inconsistent with 200 responses (should we then add content-type matching there?).
from got.
yeah, nvm
from got.
Related Issues (20)
- Got breaks when secure renegotiation is not supported by remote resource
- Wrong type for retry option HOT 1
- `afterResponse` hook throws error on an endpoint that returns `null` when setting `responseType: 'json'`
- GOAWAY/Stream error retries not working consistently
- Catch ECONNREFUSED Error HOT 5
- response.socket.getProtocol() returns null
- Useless stack traces in got@11 HOT 4
- How to go about typing handlers?
- DNs Lookup for IP Address
- Why not CJS? HOT 1
- `stream.timings.end` property may be undefined depending on host
- Make another promise including witness and a proof agreement βprintβ HOT 2
- [V11] Update `body` error if data contains Unicode characters HOT 1
- more modern output, reducing size
- Jest has detected open handle JSSTREAM http2-wrapper HOT 1
- Stack trace back to client code
- beforeError hook not called on ERR_UNSUPPORTED_PROTOCOL
- Add options parameter to beforeRetry hook HOT 1
- Request Timeouts increase eventloop lag
- Bun throws error 'A retry listener has been attached already' HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from got.