`json` option? about got HOT 11 CLOSED

👍 I like it.

from got.

👍

P.s. just don't make it silent like in request.

from got.

Hah, I saw that too. Of course not.

from got.

Good idea, 👍

from got.

If someone have ideas, how this option should behave in Stream mode, please share - I can't think nothing better than making it exclusive for callback mode.

from got.

@floatdrop 👍

from got.

@floatdrop, by using https://github.com/dominictarr/JSONStream.

from got.

@kevva awesome module, but I tend to leave streaming on feature releases because:

• Streaming JSON is rare
• It needs some additional options (for parse and stringify/stringifyObject calls)
• It will not break compatibility, if we add it later

Now I'm digging through issues with json-like options in other modules and implementing it right might be harder, than it looks (or I'm just over-complicating).

from got.

Yeah, haven't had a chance to look at it myself, but I agree we can leave this option for streams to future versions.

from got.

After reading some issues with json option in request one idea came up. All this noise around json option comes from the fact, that enabling it have two separate effects:

1. input - it enables serializing of body (and add headers, if they not set)
2. output - parses incoming JSON

So, why don't just split them apart? For now, if we pass Object in body, we will get next error: TypeError: first argument must be a string or Buffer. What if we serialize it to JSON in this case (without setting any options)? Anyway we can't send it as is, so this seems reasonable. But two things needs to be considered:

1. is it true, that most users want to serialize objects in body option instead of throwing error?
2. if so, should we take care of toString property as well?

from got.

Partially implemented in 2.7.0 🎉

from got.