Support for binary files about got HOT 8 CLOSED

@shaunc From the docs:

Encoding to be used on setEncoding of the response data. If null, the body is returned as a Buffer.

binary is a string encoding, not actual binary nor buffer.

from got.

Yeah, I initially created this for a specific use-case I had, but I agree that would be nice.

Seems like request has an option for encoding:

encoding - Encoding to be used on setEncoding of response data. If null, the body is returned as a Buffer.

But I tend to prefer returning a buffer and let the user choose what to do with it.

OT, but curious why you're using stream.on('readable') rather than stream.on('data'). I don't get when to use which.

@floatdrop thoughts on this?

from got.

I am not an expert in streams but AFAIU:

• when readable is emitted, you can call stream.read() and it will returns some data;
• when data is emitted, you get the data directly.

One more thing: adding an handler for the data event switch the stream in flowing mode which the documentation recommends.

I think I should have used the last one.

from got.

After some more thoughts, I think non flowing mode is useful for back pressure (e.g. allowing a file stream to retrieve data only when needed) but is useless for this case.

from got.

I would prefer passing encoding into options and leave stuff related to binary data in stream mode of got. It just my opinion, but I often forget to do toString on buffers and get very obscure errors.

from got.

Hmm, yeah, when thinking about it, you'll want text in almost every case, so makes more sense to default to that. encoding option it is.

@julien-f Wanna do a PR?

from got.

Yep.

from got.

Is there any way to get response.body as a buffer if you want it that way? Seems even with {encoding: 'binary'} response body is string. Or do you have to use stream?

from got.