Comments (9)
Sure, go ahead.
from simplq-backend.
Let's discuss over the PR itself. It happens to come sorted, but we need to guarantee it.
Your PR would ensure this happens. For example something in the DB layer might change, and it would be a good to have to ensure this at service layer, or so I thought.
from simplq-backend.
Can I start working on this issue?
from simplq-backend.
Sure. This can be a good task for you after you complete #78
from simplq-backend.
Hi @daltonfury42, looks like this is still up for grabs, I'm looking to get started with #hacktoberfest in a couple of days, mind if I pick this up then if this is still an issue?
from simplq-backend.
Hi @daltonfury42 , just getting set up here - for some reason code traversal isn't working in intellij for me, do you have any tips?
Also, how should the responses be sorted, oldest first or newest first?
from simplq-backend.
Not sure why. It's working at my end. 🤔
You should open simplQ-backend/complete
, it should open as a maven project. Try mvn clean package
from within intellij... but this shouldn't have to do with code traversal
Oldest first.
from simplq-backend.
Hm ok, i'll see why else traversal could not work.
I tried to simulate the scenario to check the current behaviour and it looks like it already returns oldest first?
Do you have an irc/discord/telegram to discuss further?
from simplq-backend.
Makes sense, especially considering that you're using different database in local and in prod it's good to explicitly ensure consistent behaviour.
I have incorporated your feedback in the PR.
from simplq-backend.
Related Issues (20)
- Memory Leak
- Accidently pushed credentials to git, have to regerate
- PATCH Request to have a MAX_QUEUE_CAPACITY HOT 3
- Dockerise SimplQ to enable self hosting HOT 26
- Regression: Server responds with 500 error to every request HOT 1
- Automate Liquibase migration from CI
- Inconsistency in queue state HOT 3
- Backend Support for queue history HOT 9
- Add health checks for production. HOT 1
- We should have a validator class for queue and token objects HOT 1
- Bug: Adding someone with the same name again into the queue doesn't work. HOT 1
- TechDebt: Remove overloaded status enums. HOT 4
- Hardcoded URL in Token.java HOT 4
- getOwnerOrElseCreate() in OwnerService uses orElse instead of orElseGet HOT 6
- Update README HOT 3
- Bug: Queue name uniqueness constraint not present in DB.
- Fix Duplicate Queue Name Issue HOT 2
- Add API to export queue events as CSV HOT 1
- New queues can't be created with the deleted queue names HOT 4
- Same token number assigned to multiple people
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from simplq-backend.