Code Monkey home page Code Monkey logo

Comments (9)

daltonfury42 avatar daltonfury42 commented on June 18, 2024 1

Sure, go ahead.

from simplq-backend.

daltonfury42 avatar daltonfury42 commented on June 18, 2024 1

Let's discuss over the PR itself. It happens to come sorted, but we need to guarantee it.

Your PR would ensure this happens. For example something in the DB layer might change, and it would be a good to have to ensure this at service layer, or so I thought.

from simplq-backend.

nikita-tyagi avatar nikita-tyagi commented on June 18, 2024

Can I start working on this issue?

from simplq-backend.

daltonfury42 avatar daltonfury42 commented on June 18, 2024

Sure. This can be a good task for you after you complete #78

from simplq-backend.

dhirenmathur avatar dhirenmathur commented on June 18, 2024

Hi @daltonfury42, looks like this is still up for grabs, I'm looking to get started with #hacktoberfest in a couple of days, mind if I pick this up then if this is still an issue?

from simplq-backend.

dhirenmathur avatar dhirenmathur commented on June 18, 2024

Hi @daltonfury42 , just getting set up here - for some reason code traversal isn't working in intellij for me, do you have any tips?
Also, how should the responses be sorted, oldest first or newest first?

from simplq-backend.

daltonfury42 avatar daltonfury42 commented on June 18, 2024

Not sure why. It's working at my end. 🤔

You should open simplQ-backend/complete, it should open as a maven project. Try mvn clean package from within intellij... but this shouldn't have to do with code traversal

Oldest first.

from simplq-backend.

dhirenmathur avatar dhirenmathur commented on June 18, 2024

Hm ok, i'll see why else traversal could not work.
I tried to simulate the scenario to check the current behaviour and it looks like it already returns oldest first?
image

Do you have an irc/discord/telegram to discuss further?

from simplq-backend.

dhirenmathur avatar dhirenmathur commented on June 18, 2024

Makes sense, especially considering that you're using different database in local and in prod it's good to explicitly ensure consistent behaviour.
I have incorporated your feedback in the PR.

from simplq-backend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.