Comments (6)
Yes, that's correct. If the user "cancels" the login, it's not called. I'd be open to having it call back with an error; is there a specific use case you're looking for, where you need that information?
from simplicity.
Nothing specific I just want to be called when its cancelled. I'm modifying the status bar style before opening the modal and I'd like to restaure it after closing as I do when the user accept or deny the login.
I think it would be great if you use the same callback with an additional error type for this kind of cancel because someone could use that info. It's still different than denying the login.
from simplicity.
OK, I looked into this more today, and determined that it may not be a good thing to return it in the regular callback, since the callback is designed to be kind of "fool proof". If you're a lazy developer, you can just make an UIAlertView
if error is not nil, and print out the error's description. Having a dialog saying "Error: you cancelled the login" would not make sense in normal circumstances.
Any ideas for how I can incorporate this without introducing undesired behavior?
I think earlier someone asked to get the Safari object from Simplicity so they can "present" it themselves; if that's the case you could attach to the delegate yourself. Or, I can modify Simplicity to just give you the URL, and have you initiate the Safari / app:openURL
flow.
from simplicity.
The why not another optional callback? I think it's nice to have the safari view inside the lib it provide a cleaner usability for the lib users
from simplicity.
Any updates?
from simplicity.
We can add an optional callback; feel free to submit a pull request :)
from simplicity.
Related Issues (20)
- Google plus login not working HOT 4
- Issue regarding presenting safari viewcontroller from root view controller HOT 2
- Getting public_profile,email HOT 1
- pod not updated for swift 3.0 HOT 3
- Modals and safaryViewController bug HOT 2
- Multiple app launch HOT 1
- Extracting data out of AccessToken HOT 4
- Facebook returns AccessToken with no E-Mail-Information HOT 2
- Modifying autolayout from background thread HOT 5
- Objective-c HOT 1
- Google login keeps asking for authorizations HOT 1
- Google token
- How to manage permissions with Facebook login HOT 1
- LINE
- App will crash if the fb scheme isn't first in CFBundleURLSchemes HOT 4
- Solution for Github SSO?
- id_token Google
- FB Login in testflight and Store
- Is this project maintained ?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from simplicity.