[3.0]: Type of SMF\Actions\Post2::$obj must be SMF\Actions\Post about smf HOT 13 CLOSED

Confirm, I didn't notice it, because I didn't log out of the forum after installation :)

Post2: protected static Post|Post2 $obj;
Login: protected static Login2|Login $obj;
Logout: protected static Login2|Logout $obj;

from smf.

I can't reproduce this error. Is anyone else able to?

from smf.

I can't reproduce this on my test board either.

from smf.

For me, this issue occurs only on PHP 8.0.30. There is no problem with PHP 8.1+

from smf.

I can reproduce on PHP 8.0.30

from smf.

I get pretty much the same issue in action=login
Type of SMF\Actions\Login::$obj must be SMF\Actions\Login2 (as in class SMF\Actions\Login2) in \Sources\Actions\Login.php on line 28

from smf.

Odd, I switched over to 8.0.30 and it works still. Must be something more.

from smf.

Are you guys on Windows? Using a WAMP-type setup? Using Apache with mod_php or something?
Trying to see what variable I am missing to produce this.

from smf.

Windows 11, PHP 8.0.30

from smf.

Same here

from smf.

@ Sesquipedalian I would like your opinion here. Looks like PHP 8.0 on Windows does not handle extending the class concerning self under $obj. PHP 8.0 is already EOL and Windows usage is fairly low I suspect.
We seem to have two options

1. Fix the code as suggested above, removing reference to self in the base class and using the unions of the base and extended classes.
2. Do not support PHP 8.0 on Windows.

I'm debating this, because do we want to do a fix for this that affects a very small (maybe non-existent) under of installations?

from smf.

One more reason to increase the minimum PHP version :)

from smf.

The best solution is to set the type for all $obj properties to the class name (or the name of the extended class, if applicable). I will submit a PR shortly.

from smf.