Warning: Undefined array key "load_average" in yada\Sources\Load.php on line 382 in SSI.php about smf HOT 4 OPEN

I can't reproduce this.

from smf.

I wouldn't even suspect a corrupted $modSettings, as that should still render the !empty check false.

from smf.

It's just kinda dumb, I think...

Yes, it checks empty on 382, but nowhere prior, e.g., 372 & 374.

I think this is happening when folks are restoring Unix backups, with this enabled, into wamps, where (I think) elsewhere in load.php it deletes the settings because it knows they don't apply.

I think we just need another check on 370.

from smf.

This looks like a simple logic problem to me. Lines 382 and 386 both have this:

if (!empty($modSettings['load_average']) || $modSettings['load_average'] === 0.0)

If $modSettings['load_average'] is not set, the first check will fail, and then the second check will produce the error.

The solution should be simple. Since the existing logic is meant to check that $modSettings['load_average'] either isn't empty or else is empty only because it is zero, we can just do this:

if (isset($modSettings['load_average']))

If it's really important that the value be a float rather than, say, an integer, just cast it to a float on the next line after this check.

from smf.