Code Monkey home page Code Monkey logo

Comments (5)

vinaysshenoy avatar vinaysshenoy commented on May 29, 2024 1

Proposal 2 seems fairly easier to maintain but with this we'd still use Named annotation across the project. So the purpose of the issue still remains, right?

Kind of, the main thing we are trying to do is avoid having to type the name for the Named parameter while injecting since it's not type-safe and it's prone to developer error.

I kind of like the qualifier approach since we are removing the usage of primitives and adding information via a type itself. Maintaining a bunch of different annotations isn't that much overhead over maintaining a list of constants, IMO. In addition the qualifiers are compile time only (correct me if I am wrong here) so it won't have any impact on our build.

from simple-android.

msasikanth avatar msasikanth commented on May 29, 2024 1

I kind of like the qualifier approach since we are removing the usage of primitives and adding information via a type itself. Maintaining a bunch of different annotations isn't that much overhead over maintaining a list of constants, IMO. In addition the qualifiers are compile time only (correct me if I am wrong here) so it won't have any impact on our build.

Yes, it will behave the same way Named behaves so it should not affect our builds anymore than Named.

from simple-android.

imran0101 avatar imran0101 commented on May 29, 2024 1

Qualifier Proposal +1

from simple-android.

Honey14 avatar Honey14 commented on May 29, 2024

Proposal 2 seems fairly easier to maintain but with this we'd still use Named annotation across the project. So the purpose of the issue still remains, right?

from simple-android.

msasikanth avatar msasikanth commented on May 29, 2024

Proposal 2 seems fairly easier to maintain but with this we'd still use Named annotation across the project. So the purpose of the issue still remains, right?

Kind of, the main thing we are trying to do is avoid having to type the name for the Named parameter while injecting since it's not type-safe and it's prone to developer error.

from simple-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.