Comments (5)
Proposal 2 seems fairly easier to maintain but with this we'd still use
Named
annotation across the project. So the purpose of the issue still remains, right?Kind of, the main thing we are trying to do is avoid having to type the name for the
Named
parameter while injecting since it's not type-safe and it's prone to developer error.
I kind of like the qualifier approach since we are removing the usage of primitives and adding information via a type itself. Maintaining a bunch of different annotations isn't that much overhead over maintaining a list of constants, IMO. In addition the qualifiers are compile time only (correct me if I am wrong here) so it won't have any impact on our build.
from simple-android.
I kind of like the qualifier approach since we are removing the usage of primitives and adding information via a type itself. Maintaining a bunch of different annotations isn't that much overhead over maintaining a list of constants, IMO. In addition the qualifiers are compile time only (correct me if I am wrong here) so it won't have any impact on our build.
Yes, it will behave the same way Named
behaves so it should not affect our builds anymore than Named
.
from simple-android.
Qualifier Proposal +1
from simple-android.
Proposal 2 seems fairly easier to maintain but with this we'd still use Named
annotation across the project. So the purpose of the issue still remains, right?
from simple-android.
Proposal 2 seems fairly easier to maintain but with this we'd still use
Named
annotation across the project. So the purpose of the issue still remains, right?
Kind of, the main thing we are trying to do is avoid having to type the name for the Named
parameter while injecting since it's not type-safe and it's prone to developer error.
from simple-android.
Related Issues (20)
- A better way to add feature flags HOT 6
- `ProgressMaterialButton` HOT 16
- Migrating to Java Optional
- Instruction to setup up JDK 1.8 installation on Windows Machines (Readme) HOT 2
- Suggestion[Update Git clone command) Readme HOT 4
- Improve the navigation framework HOT 4
- Proposal for automatic performance reporting of SQL queries HOT 5
- Proposal for Fragment Results API HOT 12
- Setting up a regression test suite for meeting performance goals HOT 4
- Dependency Dashboard
- Reset PIN HOT 1
- Action Required: Fix Renovate Configuration
- Reporting a vulnerability HOT 2
- Hide "Record every patient…" text on home when a snackbar is visible HOT 1
- Switch to using App Bundle format for APK to reduce install file size HOT 3
- Gzip request bodies of network calls in the app HOT 4
- If the process restarts while a registration is happening, the app crashes HOT 1
- "Every patient" span of the message on the patients tab is missing on Lollipop devices HOT 1
- Build a custom view to enable fast entry of blood pressures HOT 12
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from simple-android.