Comments (9)
I am not an expert in optimization but in the article the issue where about views never displayed because they are covered by another view.
In the case of this lib, to not have 2 layers you would have to destroy the menu each time it s hided, right ?
So it means you would have to recreate the menu each time the user wants to use it. It takes time. So no more butter experience!
The hided view here is useful, not like a view you will never see. Even if sometimes it is under another one.
from android-menudrawer.
@SimonVT and myself talked about this briefly on IRC. Can't remember where we came down but I think it has something to do with the fact that the library uses hardware layers. Probably still should be setting the drawer to View.GONE
when fully closed.
from android-menudrawer.
I'm a bit concerned about what will happen with the hardware layer if the visibility is set to gone. If its destroyed, it can take something like 50-100ms to recreate once it is shown again, which is not acceptable. If that is the case, simply moving the view off screen might be a better solution.
from android-menudrawer.
Can we do something with calling setWillNotDraw
when fully closed?
from android-menudrawer.
I don't think so. I wrap the menu layout in a framelayout, which doesn't do
any drawing. setWillNotDraw doesn't propagate to child views.
I'll have to investigate what exactly happens when visibility is toggled
before deciding what to do, but I don't really think we want to cause a
redraw of the menu (which will have to happen when its shown again).
Keeping the hardware layer as-is, but off screen, might be faster.
On Dec 6, 2012 12:04 AM, "Jake Wharton" [email protected] wrote:
Can we do something with calling setWillNotDraw when fully closed?
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-11065325.
from android-menudrawer.
Custom FrameLayout
that doesn't dispatch drawing to children when drawer is closed?
from android-menudrawer.
Is onDraw called at all unless the menu view is invalidated? I think this
might be all in the GPU.
On Dec 6, 2012 12:46 AM, "Jake Wharton" [email protected] wrote:
Custom FrameLayout that doesn't dispatch drawing to children when drawer
is closed?—
Reply to this email directly or view it on GitHubhttps://github.com//issues/44#issuecomment-11066743.
from android-menudrawer.
Should be fixed. The selected solution was to move the menu off screen when drawer is closed, and hardware layers are used, since e.g. toggling visibility caused noticeable delay the first time the drawer was opened.
from android-menudrawer.
Nice work. Thank you Simon
from android-menudrawer.
Related Issues (20)
- Left menu over the action bar HOT 1
- menudrawer with Toolbar HOT 1
- the right side overlaydrawer could not drag freely as left side.
- Menu drawer toggle events HOT 1
- I wonder how can I do menudrawer to not be animated at activity starting time.
- why it's deprecated? HOT 5
- Can't use library using gradle HOT 1
- StackOverflow Issue
- FloatMath has been removed in API 23 HOT 2
- Can I draw the menu with a button click HOT 1
- issue on drawer item click
- drawer item one is to show and another hide
- Noclass definition found
- Use menudrawer across multiple activities
- how to disable open by dragging the edge?
- some think bug on aapt2 HOT 1
- java.lang.UnsupportedOperationException: Can't convert to dimension: type=0x1c HOT 7
- How to remove MenuDrawer from my rootView
- Menudrawer left menu Crash just in android API 16 & 17
- Crashed!!! java.lang.UnsupportedOperationException: Can't convert value at index 2 to dimension: type=0x3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from android-menudrawer.