Code Monkey home page Code Monkey logo

Comments (2)

scpeters avatar scpeters commented on May 13, 2024

The following is a partial fix:

diff --git a/SimTKcommon/BigMatrix/include/SimTKcommon/internal/BigMatrix.h b/SimTKcommon/BigMatrix/include/SimTKcommon/internal/BigMatrix.h
index 64fbbe4..943ca58 100644
--- a/SimTKcommon/BigMatrix/include/SimTKcommon/internal/BigMatrix.h
+++ b/SimTKcommon/BigMatrix/include/SimTKcommon/internal/BigMatrix.h
@@ -3632,6 +3632,11 @@ public:
         --index;
         return current;
     }
+    VectorIterator operator+=(ptrdiff_t n) {
+        assert (index+n-1 < vector.size());
+        index += n;
+        return *this;
+    }
     bool operator<(VectorIterator iter) const {
         return (index < iter.index);
     }

I'll make a pull request once I've tested it fully.

from simbody.

sherm1 avatar sherm1 commented on May 13, 2024

Thanks, Steve! A couple of thoughts:

  • Should have a -= operator also to avoid future problems
  • Since ptrdiff_t is signed the assert should probably be something like
    assert(0 <= index+n && index+n <= vector.size());

from simbody.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.