Comments (2)
Turns out the gridfield edit form doesn't have the tab highlight functionality, so this is specific to editing SiteTree
.
Confirmed that this is only incorrect when using validation from form fields, which for some reason use "validation" as the error type, which isn't technically a valid type (should use one of the consts on ValidationResult
), but it's been there forever so we can't just change that in a patch.
I'll make a PR with the minimal change required to fix this.
from silverstripe-cms.
Thanks for raising this. It's definitely a bug.
I'm not sure what you mean by "page error". We have two validation error messages here:
EmailField
form field validation error message - this is a form validation errorRequiredFields
validator error message - this is a form validation error
The only difference I can see between the two with a quick glance is that one uses the "required" message type, and the other uses the "validation" message type - but both should definitely display the same way.
I would expect a "page error" to be one that comes from the validate()
method on your page. Did you check whether that one indicates the tab or not?
You've raised this against the silverstripe/silverstripe-cms
repository - does this mean you have confirmed that these both behave/display the same way when editing records in a GridField
(e.g. in a ModelAdmin
)?
from silverstripe-cms.
Related Issues (20)
- Refactor CMSMain and its subclasses HOT 1
- TODO: Should ContentController::LoginForm() return all available log-in forms? HOT 1
- [bug] Bulk actions allow unpublishing of homepage without confirmation
- 5.1: Can't open settings tab of SiteTree objects, if you have a lot of members HOT 12
- Redirector page in Menu does not return expected isCurrent() value. HOT 1
- Insert from Files button not working in TinyMCE editor HOT 4
- Jumping to random CMS tabs when navigating pages HOT 3
- TinyMCE - Adding a link to a page on this site and then clicking through to the immediate child pages takes you down two levels rather than one HOT 1
- SPIKE Analyse how LeftAndMain and CMSMain are put together and how they could work better HOT 7
- Don't hardcode `SiteTree` in `CMSMain`
- Refactor history tab `CMSMain`/`HierarchyModelAdmin`
- Refactor tree filtering in `CMSMain`/`HierarchyModelAdmin`
- Refactor batch actions in `CMSMain`/`HierarchyModelAdmin`
- Make an abstract class for managing hierarchical data in a tree view
- Refactor `ModelAsController` to be generic
- Refactor `ContentController` to be generic
- Refactor `RootURLController` to be generic
- Remove old installer logic from ContentController HOT 1
- Duplicate breadcrumb labels when navigating site tree in ListView HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from silverstripe-cms.