Code Monkey home page Code Monkey logo

Comments (2)

GuySartorelli avatar GuySartorelli commented on August 25, 2024 1

Turns out the gridfield edit form doesn't have the tab highlight functionality, so this is specific to editing SiteTree.
Confirmed that this is only incorrect when using validation from form fields, which for some reason use "validation" as the error type, which isn't technically a valid type (should use one of the consts on ValidationResult), but it's been there forever so we can't just change that in a patch.

I'll make a PR with the minimal change required to fix this.

from silverstripe-cms.

GuySartorelli avatar GuySartorelli commented on August 25, 2024

Thanks for raising this. It's definitely a bug.

I'm not sure what you mean by "page error". We have two validation error messages here:

  1. EmailField form field validation error message - this is a form validation error
  2. RequiredFields validator error message - this is a form validation error

The only difference I can see between the two with a quick glance is that one uses the "required" message type, and the other uses the "validation" message type - but both should definitely display the same way.

I would expect a "page error" to be one that comes from the validate() method on your page. Did you check whether that one indicates the tab or not?

You've raised this against the silverstripe/silverstripe-cms repository - does this mean you have confirmed that these both behave/display the same way when editing records in a GridField (e.g. in a ModelAdmin)?

from silverstripe-cms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.