Comments (4)
emteknetnz
commented on August 25, 2024
1
I spent the better part of a day on this, it seems like it's fairly difficult to get this going
Recommend whoever picks this up again (if we even bother) approaches this from a "rebuild" mentality rather than an "upgrade" mentality
from silverstripe-cms.
emteknetnz
commented on August 25, 2024
@sabina-talipova I've merged the PRs you created - there's still this draft PR though - silverstripe/silverstripe-pattern-lib#3
https://github.com/silverstripe/silverstripe-pattern-lib is used to build a static version of the pattern-lib each day which is hosted on a github page at https://silverstripe.github.io/silverstripe-pattern-lib/ - are you happy to ensure this is working as it should?
from silverstripe-cms.
sabina-talipova
commented on August 25, 2024
I have created new ticket to fix 4 spaces indent issue and make additional enhancement.
from silverstripe-cms.
sabina-talipova
commented on August 25, 2024
All PRs have been merged. Close this issue.
from silverstripe-cms.
Related Issues (20)
- CMS shows unwanted horizontal scrollbar in Chrome and Safari HOT 1
- LeftAndMainPageIconsExtension::generatePageIconsCss is called twice HOT 1
- SiteTree link tracking can cause fatal error when using “Cancel draft changes” HOT 4
- VirtualPage uses hardcoded 'admin' in the edit link HOT 3
- CMS 5.1.0-beta1. Regression testing: Broken UI for "URL segment" buttons "OK" and "Cancel" HOT 2
- EPIC Search provider integration UI
- Editor link modals erroring for internal and anchor link types HOT 3
- Cancel draft changes UI component doesn't show up for draft changes on owned models HOT 1
- Add tests for canAddChildren() and canCreate() methods in SiteTreePermissionsTest
- Use NestedTitle instead of Title in various reports
- Change the `BackLinks` relation in `SiteTree` to a polymorphic many_many relation
- Refactor CMSMain and its subclasses HOT 1
- TODO: Should ContentController::LoginForm() return all available log-in forms? HOT 1
- [bug] Bulk actions allow unpublishing of homepage without confirmation
- 5.1: Can't open settings tab of SiteTree objects, if you have a lot of members HOT 12
- Redirector page in Menu does not return expected isCurrent() value. HOT 1
- Insert from Files button not working in TinyMCE editor HOT 4
- Jumping to random CMS tabs when navigating pages HOT 3
- TinyMCE - Adding a link to a page on this site and then clicking through to the immediate child pages takes you down two levels rather than one HOT 1
- SPIKE Analyse how LeftAndMain and CMSMain are put together and how they could work better HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from silverstripe-cms.