Rollouts are now rolling back about ecs-deploy HOT 11 CLOSED

I think the default should be not to rollback since that is a breaking change for you and probably others, the flag will be needed to enable rollback.

from ecs-deploy.

Well, there was another place in the code that called the rollback function that I forgot to wrap in a condition for the flag so I just updated it and pushed 3.1.1.

Again, sorry for the problems :-(

from ecs-deploy.

@jeremypumphrey yes, this feature just rolled out today that if the deployment does not complete in the timeframe it rolls back. I'm sorry this is causing a problem for you, I'll update it to be an optional setting with new parameter. I my use case I set a longer timeout to ensure it is successful or otherwise consider the deployment a failure, this just makes it safer if it fails to start up for me.

from ecs-deploy.

Other than increasing the -t to 10 minutes (time to roll out completely in my case), is there a flag to simply ignore the failure and not roll back?

from ecs-deploy.

--ignorefailure or --norollback

from ecs-deploy.

I'm adding the flag now, will be done shortly.

from ecs-deploy.

Fixed in version 3.1, see #103

from ecs-deploy.

Docker image still building though...https://hub.docker.com/r/silintl/ecs-deploy/builds/

from ecs-deploy.

I waited for 3.1 to complete and tested. Still seeing the rollback behaviour.

$ docker run -it --rm -e AWS_ACCESS_KEY_ID=$AWS_ACCESS_KEY_ID -e AWS_SECRET_ACCESS_KEY=$AWS_SECRET_ACCESS_KEY -e AWS_DEFAULT_REGION=us-east-1 silintl/ecs-deploy --cluster CTRP-IntTest-Backend --service-name CTRP-ctrp_import_ct_api-INTTEST -i $DOCKER_IMAGE:$DATE
Unable to find image 'silintl/ecs-deploy:latest' locally
latest: Pulling from silintl/ecs-deploy
Status: Downloaded newer image for silintl/ecs-deploy:latest
Using image name: ctrp/ctrp_import_ct_api:05-01-17-1536
Current task definition: arn:aws:ecs:us-east-1:127516845550:task-definition/CTRP-ctrp_import_ct_api-INTTEST:146
New task definition: arn:aws:ecs:us-east-1:127516845550:task-definition/CTRP-ctrp_import_ct_api-INTTEST:148
Service updated successfully, new task definition running.
Waiting for service deployment to complete...
Rolling back to arn:aws:ecs:us-east-1:127516845550:task-definition/CTRP-ctrp_import_ct_api-INTTEST:146

from ecs-deploy.

@jeremypumphrey I'm thinking you did not get 3.1, can you check the source in that image to see if the enable-rollback flag is present? I tested with and without the parameter and observed it behaved as expected.

from ecs-deploy.

Apologies, there might have been a lag from when DockerHub said it was posted and when it could actually be pulled. Seems to be working as before again now:

Status: Downloaded newer image for silintl/ecs-deploy:latest
Using image name: fnlcr/nci-adult-match-ui:05-01-17-1552
Current task definition: arn:aws:ecs:us-east-1:127516845550:task-definition/AdultMATCH-nci-adult-match-ui-INTTEST:107
New task definition: arn:aws:ecs:us-east-1:127516845550:task-definition/AdultMATCH-nci-adult-match-ui-INTTEST:111
ERROR: New task definition not running within 90 seconds

from ecs-deploy.