Describe the bug The workflow contains animatediff node and ipadap

please try it test case <a class="user-mention notranslate" data-hovercard-type="user"

please try it test case <a class="user-mention notranslate" data-hovercar

Cannot update ipadapter weight after compiling the graph in ComfyUI about onediff HOT 4 CLOSED

Gutianpei commented on August 23, 2024

Cannot update ipadapter weight after compiling the graph in ComfyUI

from onediff.

Comments (4)

ccssu commented on August 23, 2024

Debug found that the inability to update is due to an issue with the torch workflow：

The workflow weight did not change to a list, but rather to a float, as follows：
https://github.com/cubiq/ComfyUI_IPAdapter_plus/blob/d33265adf72974213fd4ea9bdbba1d0f176e7658/CrossAttentionPatch.py#L148-L151

# ComfyUI/custom_nodes/ComfyUI_IPAdapter_plus/CrossAttentionPatch.py:161
    else:
        out_ip = optimized_attention(q, ip_k, ip_v, extra_options["n_heads"])
        import pdb; pdb.set_trace()
        out_ip = out_ip * weight # I'm doing this to get the same results as before

  /data/home/fengwen/quant/ComfyUI/comfy/ldm/modules/attention.py(456)forward()
-> return checkpoint(self._forward, (x, context, transformer_options), self.parameters(), self.checkpoint)
  /data/home/fengwen/quant/ComfyUI/comfy/ldm/modules/diffusionmodules/util.py(191)checkpoint()
-> return func(*inputs)
  /data/home/fengwen/quant/ComfyUI/comfy/ldm/modules/attention.py(554)_forward()
-> n = attn2_replace_patch[block_attn2](n, context_attn2, value_attn2, extra_options)
  /data/home/fengwen/quant/ComfyUI/custom_nodes/ComfyUI_IPAdapter_plus/CrossAttentionPatch.py(38)__call__()
-> out = out + callback(out, q, k, v, extra_options, **self.kwargs[i])
> /data/home/fengwen/quant/ComfyUI/custom_nodes/ComfyUI_IPAdapter_plus/CrossAttentionPatch.py(164)ipadapter_attention()
-> out_ip = out_ip * weight # I'm doing this to get the same results as before
(Pdb) p 
*** SyntaxError: invalid syntax
(Pdb) p weight
1.0

from onediff.

ccssu commented on August 23, 2024

please try it test case @Gutianpei https://github.com/siliconflow/onediff/tree/3aad30db09d13a22c75fee1f11230fcb8562de6a/onediff_comfy_nodes/modules/oneflow/hijack_ipadapter_plus#ipadapter_weights

from onediff.

Gutianpei commented on August 23, 2024

please try it test case @Gutianpei https://github.com/siliconflow/onediff/tree/3aad30db09d13a22c75fee1f11230fcb8562de6a/onediff_comfy_nodes/modules/oneflow/hijack_ipadapter_plus#ipadapter_weights