Code Monkey home page Code Monkey logo

Comments (6)

sile avatar sile commented on September 18, 2024 1

This is a somewhat interesting issue. Please let me consider the feasibility of this feature this weekend.

from amf.

crumblingstatue avatar crumblingstatue commented on September 18, 2024 1

Thank you very much!

from amf.

sile avatar sile commented on September 18, 2024

I found a description about reference table in AMF 3 specification as below.

Similar to AFM 0, AMF 3 object reference tables, object trait reference tables and string reference tables must be reset each time a new context header or message is processed.
-- 4.1 NetConnection and AMF 3

I think that it means that {amf0,amf3}::Decoder::decode methods should not clear the reference tables automatically after decoding a value (so the current implementation seems wrong...).

IMO, it seems better to split the current decode method into two methods as follows:

impl Decoder {
    pub fn decode(&mut self) -> DecodeResult<Value> {
        self.decode_value()
    }

   pub fn clear_reference_tables(&mut self) {
        self.traits.clear();
        self.strings.clear();
        self.complexes.clear();
   }
}

What do you think of it? > @crumblingstatue

from amf.

crumblingstatue avatar crumblingstatue commented on September 18, 2024

That looks good to me, it would be nice, thank you!

from amf.

sile avatar sile commented on September 18, 2024

Thank you for your swift reply. I created #5 to reflect the above idea.

from amf.

sile avatar sile commented on September 18, 2024

Published: https://crates.io/crates/amf/0.3.0

from amf.

Related Issues (4)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.