Code Monkey home page Code Monkey logo

Comments (6)

sigaloid avatar sigaloid commented on August 15, 2024

Added, let me know if you need any help!

from libretranslate.net.

arivera12 avatar arivera12 commented on August 15, 2024

Give me a few hours cause I am on duty atm.

Can you license this software?

Maybe MIT license could be good?

So I can include the license the nuget package.

All credits goes to you since you are the founder, I will just push the nuget package for you.

from libretranslate.net.

arivera12 avatar arivera12 commented on August 15, 2024

Btw if you can downgrade the .net version of the package to it's minimum requirement would be awesome.

So it will be more portable to other .net versions

Take a look of this.

https://docs.microsoft.com/en-us/dotnet/standard/net-standard

I don't see any requirements of this library that needs to be on NET5

from libretranslate.net.

arivera12 avatar arivera12 commented on August 15, 2024

Looking at the source code I think we should do some refactoring to the source.

I will take a look later of the implementation and improve it in a new branch and pull a request to the main branch.

from libretranslate.net.

sigaloid avatar sigaloid commented on August 15, 2024

Can you license this software?

MIT works, yeah. Added

Btw if you can downgrade the .net version of the package to it's minimum requirement would be awesome.

Looking at the source code I think we should do some refactoring to the source.

Yep, I chose .net 5 because it was the default, I was actually just speed-running creating a library :D I didn't put much thought into it. If you'd like to make a PR with both of these changes, that would be great; if you need any help or need me to, I can try to help. Not sure what refactoring you mean, IIRC I ran Jetbrains refactor before pushing it. Feel free to add a PR!

from libretranslate.net.

arivera12 avatar arivera12 commented on August 15, 2024

Don't worry spec my PR on these days on a weekend. I in a hurry on theses days. I will create 2 new issues with task so we can keep tracking.

from libretranslate.net.

Related Issues (7)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.