Code Monkey home page Code Monkey logo

Comments (4)

 avatar commented on June 24, 2024

The simple solution is to just remove the .tolist() method from data['X'] and data['y]

def train_hill_model(df, mc_df, adstock_params, media, sm):
    data, sc = create_hill_model_data(df, mc_df, adstock_params, media)
    fit = sm.sampling(data=data, iter=2000, chains=4)
    fit_result = fit.extract()
    hill_model = {
        'beta_hill_list': fit_result['beta_hill'].tolist(),
        'ec_list': fit_result['ec'].tolist(),
        'slope_list': fit_result['slope'].tolist(),
        'sc': sc,
        'data': {
            'X': data['X'],
            'y': data['y'],
        }
    }
    return hill_model

from mmm_stan.

sibylhe avatar sibylhe commented on June 24, 2024

Thanks for pointing out this! Your solution is correct.
tolist() is used to save the model as json file, because arrays cannot be saved as json. I will revise those model saving and loading functions later this weekend.

from mmm_stan.

 avatar commented on June 24, 2024

No problem! Thanks for putting this together; I've found it quite helpful.

from mmm_stan.

sibylhe avatar sibylhe commented on June 24, 2024

For the sake of model storage, I still prefer to store data['X'] and data['y'] as lists, so that the hill model can be saved as json using save_json(). I modified evaluate_hill_model(), converting them to arrays.

from mmm_stan.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.