Code Monkey home page Code Monkey logo

Comments (8)

andyb2000 avatar andyb2000 commented on June 28, 2024 1

Yep, spotted this after testing and talking to @sibbl about another issue with env's so looks like it's due to the line 308 in index.js ( .dither(pageConfig.dither))

I may get time tomorrow to take a quick look.

from hass-lovelace-kindle-screensaver.

sibbl avatar sibbl commented on June 28, 2024 1

The cause of this might be that our Dockerfile uses imagemagick instead of graphicsmagick. While the used npm module gm says to be compatible with both, it doesn't seem to support the differences in the dither parameter. While +dither works for both, the -dither parameter requires the name of the dither algorithm to use in imagemagick, while graphicsmagick only uses it as a toggle.

Maybe it's worth to give Graphicsmagick another try in the Dockerfile but I'm not sure what other incompatibilities will occur.
An alternative would be to open an issue in the gm npm package repository.
Finally, we could also just use the "custom arguments" feature of the gm npm package to support -dither ALGORITHM and ยด+dither` by our own. That's probably what I'd prefer.

from hass-lovelace-kindle-screensaver.

GoodnessJSON avatar GoodnessJSON commented on June 28, 2024

Yep, spotted this after testing and talking to @sibbl about another issue with env's so looks like it's due to the line 308 in index.js ( .dither(pageConfig.dither))

I may get time tomorrow to take a quick look.

That would be amazing, thanks for taking a look!

from hass-lovelace-kindle-screensaver.

GoodnessJSON avatar GoodnessJSON commented on June 28, 2024

This only seemed to come with the update to Home Assistant yesterday, as well as the v1.0.7 update today. I'm not sure if that helps at all. Node.js v18.19.1 running HAOS on a RPB4.

from hass-lovelace-kindle-screensaver.

sibbl avatar sibbl commented on June 28, 2024

Oh, now I understand. After the update, it doesn't work either way - with and without the toggle? I thought it was just a problem after enabling it.

As a quick fix, I'll remove the option again until we can find out the real cause. Version 1.0.8 will be available in a few minutes.

from hass-lovelace-kindle-screensaver.

GoodnessJSON avatar GoodnessJSON commented on June 28, 2024

Oh, now I understand. After the update, it doesn't work either way - with and without the toggle? I thought it was just a problem after enabling it.

As a quick fix, I'll remove the option again until we can find out the real cause. Version 1.0.8 will be available in a few minutes.

Yep that's correct! No matter the setting, or after reinstalling it's the same error. Thanks for taking a look! Will let you know about v1.0.8. Thanks for the quick responses!

from hass-lovelace-kindle-screensaver.

GoodnessJSON avatar GoodnessJSON commented on June 28, 2024

Can confirm this has now fixed it. Great work!

from hass-lovelace-kindle-screensaver.

sibbl avatar sibbl commented on June 28, 2024

Thanks for the confirmation and sorry that it happened in the first place!

from hass-lovelace-kindle-screensaver.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.