Code Monkey home page Code Monkey logo

Comments (7)

jonaro00 avatar jonaro00 commented on September 10, 2024 1

No, bumping it in the workspace will require a lot more work.
The crates listed are not members of the workspace.

Just noticed that diesel-async 0.5.0 is also available. If you get done with sqlx, you can take a stab at that as well (same thing, but no examples need updates).

from shuttle.

jonaro00 avatar jonaro00 commented on September 10, 2024 1

Since they are not workspace members, you need to cd to their directories before using cargo commands.
The crates in question don't have tests, but they need to compile with various sets of feature flags.
Our CI, which will run when you make the PR, should cover the needed cases.

from shuttle.

sentinel1909 avatar sentinel1909 commented on September 10, 2024

I'd be happy to take this one and get 'er done.

from shuttle.

sentinel1909 avatar sentinel1909 commented on September 10, 2024

I've started working this issue. Is it desired to update to sqlx 0.8.0 at the workspace level? I ask because, after opening a new branch I which to work, I changed the dependency at the workspace level and immediately hit trouble in resources..

I'll post a snip of the specifics a bit later. Just want to confirm the scope of work, so to speak.

from shuttle.

sentinel1909 avatar sentinel1909 commented on September 10, 2024

Alright...I'm a little embarrassed, but it's been awhile since I worked on the code base. Do I have to spin up locally when testing? I did cargo test from the project root, half the tests passed and half failed...figured I must be missing something.

Just need a pointer or two to set off in the right direction here.

Thanks,

~Jeff

from shuttle.

sentinel1909 avatar sentinel1909 commented on September 10, 2024

Pull request submitted. Will work on shuttle-examples next.

from shuttle.

ccmvn avatar ccmvn commented on September 10, 2024

Thanks for the work, I had reported the problem myself on Discord a few days ago, but didn't have time to work on it myself @sentinel1909

from shuttle.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.