Code Monkey home page Code Monkey logo

Comments (5)

arski avatar arski commented on May 12, 2024

correction, the tooltip is activated at both left AND right edges, but not between them :o

from rickshaw.

arski avatar arski commented on May 12, 2024

wow, found the bug.. in Rickshaw.Graph.HoverDetail there is a line saying
if (e.target.nodeName != 'path' && e.target.nodeName != 'svg') return;
however, in bar plots, the bar itself is a rect.. so changing that to
if (e.target.nodeName != 'path' && e.target.nodeName != 'svg' && e.target.nodeName != 'rect') return;
fixes things.

from rickshaw.

peterhellberg avatar peterhellberg commented on May 12, 2024

Thank you, I had the same issue the other day.

from rickshaw.

arski avatar arski commented on May 12, 2024

Actually, I think that e.target.nodeName != 'svg' should be removed from there.. since when you're hovering over the canvas itself, i.e. not one of the bars or areas, you shouldn't be triggering any tooltips (which won't be shown anyway, it just does all the useless processing..)

from rickshaw.

dchester avatar dchester commented on May 12, 2024

Thanks!

Actually, I think that e.target.nodeName != 'svg' should be removed from there.

It gets tricky with scatter plots and lines. Since they're such small targets, it's nice now that you don't have to work too hard to see the tooltips.

Whitelisting rect gets us going for now, but it might be nicer to have renderers register relevant elements directly in the future.

from rickshaw.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.