Code Monkey home page Code Monkey logo

Comments (9)

shyim avatar shyim commented on May 19, 2024 2

@NeoBlack
The current pinning helps us to have a reproduceable build. We have already a ticket open to reconsider it https://issues.shopware.com/issues/NEXT-9961

from shopware.

shyim avatar shyim commented on May 19, 2024 1

It's not the same. Shopware has two distributions ways zip version and composer. In the Zip your comment would work. But when somebody depend on Shopware using composer only the require from composer.json will be restrictet.

Locking for a specific version makes the lifes for our support team easier, because we have only to check the Shopware version and not of the dependencies. We had already tickets, where a single patch version difference in Symfony broke the complete shop registration and address managment

from shopware.

szepeviktor avatar szepeviktor commented on May 19, 2024 1

@shyim Yes! That is fine. I encourage you to do that, just by the means of the composer.lock file.

  • you could do build/test with locked versions
  • with downgraded versions
  • with latest versions

kÊp

https://getcomposer.org/doc/01-basic-usage.md#installing-with-composer-lock

from shopware.

shyim avatar shyim commented on May 19, 2024 1

I just explained our current point why we do it and didn't said we are against that 😊 .
We will look into that linked issue and come back with feedback 😊

from shopware.

szepeviktor avatar szepeviktor commented on May 19, 2024

Okay. I see, you have incompetent users.
I am sorry.

from shopware.

szepeviktor avatar szepeviktor commented on May 19, 2024

where a single patch version difference in Symfony broke

@shyim If you encounter an issue use version exclusion: "symfony/something": "^3.1.41 !=3.1.42"

But I understand the business is the main thing.

from shopware.

NeoBlack avatar NeoBlack commented on May 19, 2024

pinning the version in the composer.json file is a pain in the ass for the other developers, who code plugins or try to manage bigger installations. It is stupid to pin package versions in a composer product.
Other systems also have zip releases and don't pin packages to a specific version. I guess you don't understand how package management works. Really sad.

from shopware.

shyim avatar shyim commented on May 19, 2024

That does not help us. This repository is an library and not an root composer project

from shopware.

szepeviktor avatar szepeviktor commented on May 19, 2024

Okay.
Please randomly pick a handful of Composer packages https://packagist.org/explore/popular
and it will be very-very difficult to find one with locked versions in the JSON file.
How could it be? (theoretical question)

from shopware.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤ī¸ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.