Comments (10)
Sorry if this is the wrong place to ask (or a silly question in general), but what is the likelihood of ruby-lsp completions becoming as thorough as the completions in irb
and rails console
? I find both of those tools have incredibly fast and detailed completions. After using them, I am often left longing for my text editor to work in the same way.
Example of irb
giving an immense list of methods I can call on a string:
Example of rails console
giving a list of all the methods I can call on my Active Record model:
Is this something that ruby-lsp and vscode-ruby-lsp could eventually achieve? Or are completions like this the responsibility of a different sort of tool?
from ruby-lsp.
Not a silly question at all! I'm not sure how these new IRB completions work internally, but they are indeed very useful - and it would be a great experience for the Ruby LSP.
I think it could be achieved, but it does require some exploration to understand how it's done. Maybe it could even be shared between IRB and the Ruby LSP? I'll add this idea to the issue description.
from ruby-lsp.
Not a silly question at all! I'm not sure how these new IRB completions work internally, but they are indeed very useful - and it would be a great experience for the Ruby LSP.
I think it could be achieved, but it does require some exploration to understand how it's done. Maybe it could even be shared between IRB and the Ruby LSP? I'll add this idea to the issue description.
That is exciting! Thanks for considering it.
I was curious how the completions work in the tools I mentioned:
rails console
loads in Rails specific libraries, then starts a new IRB instance. That is cool, I did not realise you could do that. https://github.com/rails/rails/blob/main/tools/console- IRB is where all the magic happens, and the completions look quite complex. It parses user input, searches some hard coded values/searches RDoc, and uses RDoc to return the output for IRB session. https://github.com/ruby/irb/blob/master/lib/irb/completion.rb
I am new to Ruby, so this may just be fluff
from ruby-lsp.
Yes, one is for automatic formatting and the other one is to provide completion options (since we can't know ahead of time which method the user is looking for).
from ruby-lsp.
It would indeed be much more accurate, but I think it would be unbearably slow for large Rails applications. Also, it would require the LSP to know how to boot the application, since it may not necessarily be a Rails app.
If we can figure out a way to offer completions based on static analysis only, it should be a lot faster, more maintainable and application agnostic.
from ruby-lsp.
@vinistock is #253 part of this ticket?
from ruby-lsp.
@st0012 no, onTypeFormatting
is for formatting code as the user is typing - like automatically adding the end
or adjusting indentation. This ticket is for completion on method invocations.
from ruby-lsp.
offer to add end on other keywords, such as while, until, for
Ah ok. I saw #253 adds end
keyword so I assumed they are the same as the above.
I guess the difference is #253 always append a word based on pattern, but this one is to provide completion options?
from ruby-lsp.
I think a while ago JetBrains had an experimental completion plugin for Rubymine that instantiated the application in the background and offered completions based on what is available in the runtime. This was actually painfully slow. But given Ruby's character of meta programming this is probably the only approach that can offer 100% accurate code completion.
Feel free to correct me when there are better approaches available to have exact autocompletion.
from ruby-lsp.
it would be unbearably slow for large Rails applications
Wouldn't it be possible to cache all models and their methods, and just modify the cache on changes? doesn't sound like a huge list.
from ruby-lsp.
Related Issues (20)
- Reek/Goto definition support HOT 2
- Migrate inlay hint
- Formatting with rubocop should only autocorrect layout offenses HOT 7
- Undefined method 'URI' HOT 1
- Usage without a Gemfile HOT 3
- Error running ruby-lsp in path with spaces HOT 6
- Windows CI is mis-reporting successful runs HOT 1
- Smoke test against a minimal Ruby project HOT 5
- Fix tests failing on Windows HOT 1
- Incorrect Folding for `else` HOT 6
- Exclude listeners based on registered capabilities
- Improve minitest detection accuracy
- LSP does not start when the Gemfile includes a private gem HOT 5
- Docs generated by RDoc should not display Sorbet magic comments HOT 2
- Error in Neovim LSP: `params` could be an array? HOT 4
- Migrate selection range HOT 1
- Explore a mechanism to allow for diagnostics extensions
- Allow more requests to be extended HOT 4
- Provide extensions with a logging abstraction
- Slack link requires updating
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ruby-lsp.