Comments (6)
wcandillon
commented on June 20, 2024
2
we offered the svg module has a convenience we didn't anticipate that
people would use as a full blown renderer.
Here something else would need to be done.
…On Wed, May 22, 2024 at 11:31 AM Liam Jones ***@***.***> wrote:
I will investigate the issue and advise/document accordingly.
Thank you!
We will have a look at this issue but currently Text support in SVG is
likely to not work.
I strongly recommend not relying on it.
Okay, that's probably more difficult for me. Like zhiqingchen, I'm hitting this issue via react-native-echarts which is passing a SVG string to Skia.SVG.MakeFromString.
—
Reply to this email directly, view it on GitHub or unsubscribe.
You are receiving this email because you commented on the thread.
Triage notifications on the go with GitHub Mobile for iOS or Android.
from react-native-skia.
liamjones
commented on June 20, 2024
1
I've just hit this while doing upgrades too. From what I've been able to discern so far:
The last version this worked in was 0.1.234, it's been broken since the subsequent release - 0.1.236. I've not tested all releases due to the amount of time it takes to do native builds to test each time but I've bisected between 0.1.213 (the version it was working on for us under RN 0.72) and 1.2.3 (the version I tried to upgrade to under RN 0.73).
Works in 0.1.213, 0.1.223, 0.1.233, 0.1.234.
Doesn't work in 0.1.236, 0.1.238, 0.1.241, 1.0.1, 1.1.0, 1.2.0, 1.2.3.
From looking at the diff between 0.1.234 and 0.1.236 the first thing that jumps out as possibly released is this commit which changed how fonts were looked up: 92e6bc9. The other big thing I see in this release which may have had an effect is skia moving from m119 to m122: f3042c3
I'm going to try and debug through JsiSkTypefaceFactory.h & <ImageSVG> to work out what's changed but I'm not a C++ programmer so if someone with more knowledge can help it'd be appreciated! 🙏
from react-native-skia.
wcandillon
commented on June 20, 2024
1
We will have a look at this issue but currently Text support in SVG is
likely to not work.
I strongly recommend not relying on it.
I will investigate the issue and advise/document accordingly.
…On Wed, May 22, 2024 at 10:03 AM Liam Jones ***@***.***> wrote:
I've just hit this while doing upgrades too. From what I've been able to discern so far:
The last version this worked in was 0.1.234, it's been broken since the subsequent release - 0.1.236. I've not tested all releases due to the amount of time it takes to do native builds to test each time but I've bisected between 0.1.213 (the version it was working on for us under RN 0.72) and 1.2.3 (the version I tried to upgrade to under RN 0.73).
Works in 0.1.213, 0.1.223, 0.1.233, 0.1.234.
Doesn't work in 0.1.236, 0.1.238, 0.1.241, 1.0.1, 1.1.0, 1.2.0, 1.2.3.
From looking at the diff between 0.1.234 and 0.1.236 the first thing that jumps out as possibly released is this commit which changed how fonts were looked up: 92e6bc9. The other big thing I see in this release which may have had an effect is skia moving from m119 to m122: f3042c3
I'm going to try and debug through JsiSkTypefaceFactory.h & <ImageSVG> to work out what's changed but I'm not a C++ programmer so if someone with more knowledge can help it'd be appreciated! 🙏
—
Reply to this email directly, view it on GitHub or unsubscribe.
You are receiving this email because you are subscribed to this thread.
Triage notifications on the go with GitHub Mobile for iOS or Android.
from react-native-skia.
liamjones
commented on June 20, 2024
I will investigate the issue and advise/document accordingly.
Thank you!
We will have a look at this issue but currently Text support in SVG is
likely to not work.
I strongly recommend not relying on it.
Okay, that's probably more difficult for me. Like zhiqingchen, I'm hitting this issue via react-native-echarts which is passing a SVG string to Skia.SVG.MakeFromString.
from react-native-skia.
zhiqingchen
commented on June 20, 2024
Thanks @wcandillon , this function is really useful.
from react-native-skia.
github-actions
commented on June 20, 2024
🎉 This issue has been resolved in version 1.3.2 🎉
The release is available on:
Your semantic-release bot 📦🚀
from react-native-skia.
Related Issues (20)
- Android crash: SIGSEGV HOT 1
- does not compile on android
- the new useClock doesn't update HOT 2
- Path interpolation not working when path is rendered via map and has end and start props
- Interpolation Issues When Reusing an Interpolated Path Across Multiple Path Nodes
- Android rendering artefact not working correctly HOT 3
- error in web Cannot read properties of null (reading 'rangeMin')
- Invariant Violation: View config getter callback for component `skBoxShadow`... HOT 1
- App crashes on RNSkia::JsiDomDeclarationNode::invalidateContext() HOT 1
- Android Release Builds Fail (RN 0.74+) HOT 5
- Web app crashes on Image update HOT 1
- Skia Image and makeImageFromView result image is losing quality compared to FastImage HOT 1
- Some Shader code doesn't work as expected on Android. HOT 5
- Image component not updated during update zoom in / out screen setting android
- App Hang on RenderCommandEncoder in iOS HOT 3
- Video playback issues HOT 16
- Gestures example not working HOT 1
- How to make a shape move along a predetermined path
- android build examples fails: libsvg.a missing and no known rule to make it HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-native-skia.