Code Monkey home page Code Monkey logo

Comments (3)

JKring avatar JKring commented on June 4, 2024

Never mind! This is fixable by calling image.dispose() (and probably surface.dispose()).

I've opened a PR here.

Let me know if you want me to do anything else to support (e.g. write tests!)

from react-native-skia.

wcandillon avatar wcandillon commented on June 4, 2024

Thanks for the bug report and PR. We were always very aware of these potential issues and I think we just wanted to check first if there is appetite for the headless feature first.
Please give us some time to consider the best API there. We are looking at the using keyword: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-2.html#using-declarations-and-explicit-resource-management, more specifically if it can be used on JSI host objects

from react-native-skia.

JKring avatar JKring commented on June 4, 2024

Yes! I think something like using makes a ton of sense, so that you can ensure cleanup.

No rush on this from my end! Feel free to close the Issue and the PR. I've already updated my code to call dispose on image and surface and I am monitoring it in production now!

from react-native-skia.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.