Code Monkey home page Code Monkey logo

Comments (3)

blittle avatar blittle commented on August 16, 2024 2

It looks like Shopify's admin does not allow redirects to be defined with a trailing slash, so it's probably okay for us to automatically strip trailing slashes before we query for redirects. I will make this change.

from hydrogen.

michenly avatar michenly commented on August 16, 2024 1

@johnstew its likely a bit of both. I will report it to the API team and see if there is anything we can do on the hydrogen side for now as well.

from hydrogen.

johnstew avatar johnstew commented on August 16, 2024 1

Okay, so my workaround was to copy all the code around storefrontRedirect and modify it to check if there's a slash at the end and remove it to query for the redirects.

const hasTrailingSlash = /\/$/.test(redirectFrom);
const modifiedRedirectFrom = hasTrailingSlash ? redirectFrom.replace(/\/$/, '') : redirectFrom;

const {urlRedirects} = await storefront.query(REDIRECT_QUERY, {
    variables: {
        query: `path:${modifiedRedirectFrom}`,
    },
});

from hydrogen.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.