Code Monkey home page Code Monkey logo

Comments (4)

trusktr avatar trusktr commented on May 29, 2024 1

workaround

The --sl-focus-ring-color variable doesn't have this issue because it is coded to adapt to primary color:

--sl-focus-ring-color: var(--sl-color-primary-600);

So to fix --sl-input-focus-ring-color without hard coding a color I mapped it like so in my app styles:

  --sl-input-focus-ring-color: var(--sl-focus-ring-color);
Screenshot 2024-04-04 at 7 01 38 PM

Ah, that's better!

from shoelace.

yuki24 avatar yuki24 commented on May 29, 2024

I thought about this too, but noticed that it may be difficult to pick a "one-fits-all" color. I ended up using --sl-color-primary-300 as an input focus ring color, which is different from your choice:

--sl-input-focus-ring-color: var(--sl-color-primary-300);

I wonder if it makes more sense to add a bit more coverage for the input focus ring to https://shoelace.style/getting-started/customizing.

from shoelace.

claviska avatar claviska commented on May 29, 2024

This was done before color-mix() was widely available because the focus ring used transparency. We've already solved this in Web Awesome, so I'm going to close this out :)

from shoelace.

yuki24 avatar yuki24 commented on May 29, 2024

@claviska That's really Awesome to know. Thanks!

from shoelace.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.