Comments (6)
I understood the issue now. I was able to reproduce this bug. Basically File => Download => PDF
in Google Docs fails without any effect. The bug affects not just Docs, but also Slides, Sheets, Drives, etc., and not only just Download
but also the Print
action in these apps.
I have also determined the cause of the issue. This was also reported in the PDF.js repo (mozilla/pdf.js#6106). I will look in to their solution and come up with a fix. Thanks for reporting! @JosefLitos 👍🏼
from doqment.
@JosefLitos Regarding your other queries:
I have an issue of the tab disappearing after I close ff and open it again. It ends up in my history but isn't restored automatically (as set by "restore tabs on startup").
Can you please elaborate? You mean doqment tabs disappear? I am able to restore them on startup, for PDFs on the web. Local PDFs need to be opened by drag and drop again.
clicking the download button for a normally opened pdf does download it, but also opens a new doqment tab with file param as "/pages/Try Again". Default behaviour is set to "open" though.
Yes, this is the expected behaviour. It is precisely for avoiding this that I advice to change the default behaviour from Open
to something else. Then it will not open in new tab.
Download through the builtin pdf-viewer just downloads the pdf without trying to open it again, and also asks for the location. This is just an observation, I do not know if replicating the builtin behaviour is even possible.
It is possible. There is another setting for Downloads: Always ask you where to save files
. These are all Firefox quirks, the built-in pdf viewer can overcome but extensions (and users) need to put up with. 🙃
from doqment.
Fixed in 3b525a4. Next release should be soon.
from doqment.
@JosefLitos Did you try the Download/Save button on the toolbar? This one:
It should download the currently opened PDF (the default behaviour should be set to something other than open
for this to work). Can you tell me the behaviour when you press that?
from doqment.
I apologize for not providing full context. The issue is that the download action is different from the open action and trying to download a pdf does nothing - no download, no new tab with the pdf.
Also, I have an issue of the tab disappearing after I close ff and open it again. It ends up in my history but isn't restored automatically (as set by "restore tabs on startup").
Edit: clicking the download button for a normally opened pdf does download it, but also opens a new doqment tab with file param as "/pages/Try Again". Default behaviour is set to "open" though. Download through the builtin pdf-viewer just downloads the pdf without trying to open it again, and also asks for the location. This is just an observation, I do not know if replicating the builtin behaviour is even possible.
from doqment.
Thanks @JosefLitos for finding this bug! 🙂
from doqment.
Related Issues (12)
- Add support for annotation HOT 4
- Need to set PDF.js preferences HOT 15
- Port to Chrome browser HOT 7
- How to set defaults? HOT 6
- Incompatibility with Zotero Connector HOT 4
- [Chrome] Need option to open PDFs by default HOT 7
- Lagging in viewer version compared to PDF.js upstream HOT 7
- Custom overlays? HOT 4
- (please delete)
- Two questions HOT 3
- Dark theme not working properly for some PDFs HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from doqment.